You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/11/07 16:20:49 UTC
[commons-net] 09/09: Use short array creation syntax
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 37830a5961be209c885472a5decf05216af00ad0
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Nov 7 11:20:19 2022 -0500
Use short array creation syntax
---
src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java | 2 +-
src/main/java/org/apache/commons/net/nntp/NNTPClient.java | 2 +-
src/main/java/org/apache/commons/net/util/NetConstants.java | 6 +++---
src/test/java/org/apache/commons/net/nntp/TestThreader.java | 2 +-
src/test/java/org/apache/commons/net/util/Base64Test.java | 2 +-
src/test/java/org/apache/commons/net/util/UtilTest.java | 4 ++--
6 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java b/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java
index 250a86a6..14e59883 100644
--- a/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java
+++ b/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java
@@ -66,7 +66,7 @@ public class FTPListParseEngine {
/**
* An empty immutable {@code FTPFile} array.
*/
- private static final FTPFile[] EMPTY_FTP_FILE_ARRAY = new FTPFile[0];
+ private static final FTPFile[] EMPTY_FTP_FILE_ARRAY = {};
private List<String> entries = new LinkedList<>();
private ListIterator<String> internalIterator = entries.listIterator();
diff --git a/src/main/java/org/apache/commons/net/nntp/NNTPClient.java b/src/main/java/org/apache/commons/net/nntp/NNTPClient.java
index 47b145ad..211c32b9 100644
--- a/src/main/java/org/apache/commons/net/nntp/NNTPClient.java
+++ b/src/main/java/org/apache/commons/net/nntp/NNTPClient.java
@@ -60,7 +60,7 @@ import org.apache.commons.net.util.NetConstants;
public class NNTPClient extends NNTP {
- private static final NewsgroupInfo[] EMPTY_NEWSGROUP_INFO_ARRAY = new NewsgroupInfo[0];
+ private static final NewsgroupInfo[] EMPTY_NEWSGROUP_INFO_ARRAY = {};
/**
* Parse a response line from {@link #retrieveArticleInfo(long, long)}.
diff --git a/src/main/java/org/apache/commons/net/util/NetConstants.java b/src/main/java/org/apache/commons/net/util/NetConstants.java
index aa98e764..666f12ed 100644
--- a/src/main/java/org/apache/commons/net/util/NetConstants.java
+++ b/src/main/java/org/apache/commons/net/util/NetConstants.java
@@ -28,17 +28,17 @@ public class NetConstants {
/**
* An empty immutable {@code String} array.
*/
- public static final String[] EMPTY_STRING_ARRAY = new String[0];
+ public static final String[] EMPTY_STRING_ARRAY = {};
/**
* An empty immutable {@code byte} array.
*/
- public static final byte[] EMPTY_BTYE_ARRAY = new byte[0];
+ public static final byte[] EMPTY_BTYE_ARRAY = {};
/**
* An empty immutable {link X509Certificate} array.
*/
- public static final X509Certificate[] EMPTY_X509_CERTIFICATE_ARRAY = new X509Certificate[0];
+ public static final X509Certificate[] EMPTY_X509_CERTIFICATE_ARRAY = {};
/**
* The index value when the end of the stream has been reached {@code -1}.
diff --git a/src/test/java/org/apache/commons/net/nntp/TestThreader.java b/src/test/java/org/apache/commons/net/nntp/TestThreader.java
index 17251530..21007839 100644
--- a/src/test/java/org/apache/commons/net/nntp/TestThreader.java
+++ b/src/test/java/org/apache/commons/net/nntp/TestThreader.java
@@ -28,7 +28,7 @@ import org.junit.Test;
*/
public class TestThreader {
- private static final Threadable[] EMPTY_THREADABLE_ARRAY = new Threadable[0];
+ private static final Threadable[] EMPTY_THREADABLE_ARRAY = {};
@SuppressWarnings("deprecation") // test of deprecated method
@Test
diff --git a/src/test/java/org/apache/commons/net/util/Base64Test.java b/src/test/java/org/apache/commons/net/util/Base64Test.java
index 580dd1e2..1bc1f79c 100644
--- a/src/test/java/org/apache/commons/net/util/Base64Test.java
+++ b/src/test/java/org/apache/commons/net/util/Base64Test.java
@@ -126,7 +126,7 @@ public class Base64Test {
@Test
public void testEncodeBase64ByteArrayBooleanBooleanInt() {
- final byte[] binaryData = new byte[] { '1', '2', '3' };
+ final byte[] binaryData = { '1', '2', '3' };
byte[] encoded;
encoded = Base64.encodeBase64(binaryData, false, false);
assertNotNull(encoded);
diff --git a/src/test/java/org/apache/commons/net/util/UtilTest.java b/src/test/java/org/apache/commons/net/util/UtilTest.java
index 556dc919..a4b0de86 100644
--- a/src/test/java/org/apache/commons/net/util/UtilTest.java
+++ b/src/test/java/org/apache/commons/net/util/UtilTest.java
@@ -108,7 +108,7 @@ public class UtilTest {
@Test
public void testNET550_Reader() throws Exception {
- final char[] buff = new char[] { 'a', 'b', 'c', 'd' }; // must be multiple of 2
+ final char[] buff = { 'a', 'b', 'c', 'd' }; // must be multiple of 2
final int bufflen = buff.length;
{ // Check buffer size 1 processes in chunks of 1
final Reader rdr = new CharArrayReader(buff);
@@ -144,7 +144,7 @@ public class UtilTest {
@Test
public void testNET550_Stream() throws Exception {
- final byte[] buff = new byte[] { 'a', 'b', 'c', 'd' }; // must be multiple of 2
+ final byte[] buff = { 'a', 'b', 'c', 'd' }; // must be multiple of 2
final int bufflen = buff.length;
{ // Check buffer size 1 processes in chunks of 1
final InputStream is = new ByteArrayInputStream(buff);