[GitHub] [activemq-artemis] gemmellr commented on a change in pull request #3568: ARTEMIS-3200 - remove braces from the belt and braces fix in ARTEMIS-…

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #3568:
URL: https://github.com/apache/activemq-artemis/pull/3568#discussion_r628335105



##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonAbstractReceiver.java
##########
@@ -285,13 +282,13 @@ protected void initializeCurrentLargeMessage(Delivery delivery, Receiver receive
    @Override
    public void close(boolean remoteLinkClose) throws ActiveMQAMQPException {
       protonSession.removeReceiver(receiver);
+      clearLargeMessage();

Review comment:
       If remoteLinkClose is false, it possibly shouldnt clean up the message file just yet - more of, or possibly the entire remainder, of the delivery might still be in flight and actually arrive before the peers 'response' detach closure frame arrives (assuming any does). In that case the end of the incomplete message might get processed incorrectly as a corrupted message, potentially leaving another 'large file' unclosed, or worse being considered 'complete' and processed even though the start of it has been thrown away.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org