[GitHub] [solr] atris edited a comment on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

[GitBox <gi...@apache.org>]

atris edited a comment on pull request #96:
URL: https://github.com/apache/solr/pull/96#issuecomment-859671978


   > Thanks for all the suggestions. I'll do some work on this and come back with a new PR.
   > 
   > * Use SolrCoreAware.
   > * Check input threshold values, the only reason this is usable is that they aren't checked.
   
   I am confused by your second point -- I thought your initial suggestion was that the threshold should be unbounded because the load average metric is unbounded (which is the case right now).
   
   So what exactly are you proposing to check, please? I agree that checking that the value is greater than zero is valuable, but did you have anything else in mind?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org