[jira] [Commented] (KAFKA-7075) Allow Topology#addGlobalStore to add a window store

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-7075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635191#comment-16635191 ] 

ASF GitHub Bot commented on KAFKA-7075:
---------------------------------------

lmontrieux opened a new pull request #5725: KAFKA-7075: Allow Topology#addGlobalStore to add a window store
URL: https://github.com/apache/kafka/pull/5725
 
 
   `Topology#addGlobalStore` takes any `StoreBuilder`, but `InternalTopologyBuilder#addGlobalStore` restricts it to `StoreBuilder<KeyValueStore>`. This PR relaxes the restriction in `InternalTopologyBuilder#addGlobalStore` to match `Topology#addGlobalStore`.
   
   Testing: adds a new unit test to show that a StoreBuilder<WindowStore> can be used in InternalTopologyBuilder#addGlobalStore. This required creating two new mocks, `MockWindowStore` and `MockWindowStoreBuilder`, modelled on `MockKeyValueStore` and `MockKeyValueStoreBuilder`, respectively.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow Topology#addGlobalStore to add a window store
> ---------------------------------------------------
>
>                 Key: KAFKA-7075
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7075
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Nishanth Pradeep
>            Priority: Major
>              Labels: newbie
>
> Today although {{Topology#addGlobalStore}} can take any {{StateStore}} types, the internal implementation {{InternalTopologyBuilder#addGlobalStore}} only accepts {{StoreBuilder<KeyValueStore>}}. It means if users pass in a windowed store builder in {{Topology#addGlobalStore}} it will cause a runtime ClassCastException.
> We should fix this issue by relaxing the {{InternalTopologyBuilder}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)