You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2013/11/06 02:58:18 UTC

[jira] [Commented] (HDFS-5464) Simplify block report diff calculation

    [ https://issues.apache.org/jira/browse/HDFS-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814517#comment-13814517 ] 

Konstantin Shvachko commented on HDFS-5464:
-------------------------------------------

So in regular case you will be adding 100,000 replicas to {{toRemove}} list only in order to delete most of them later. How does it make things simpler?
The delimiter lets you keep the calculated lists as small as possible, reducing memory consumption, avoiding frequent GCs.

> Simplify block report diff calculation
> --------------------------------------
>
>                 Key: HDFS-5464
>                 URL: https://issues.apache.org/jira/browse/HDFS-5464
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h5464_20131105.patch
>
>
> The current calculation in BlockManager.reportDiff(..) is unnecessarily complicated.  We could simplify the calculation.



--
This message was sent by Atlassian JIRA
(v6.1#6144)