You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by devaraj-kavali <gi...@git.apache.org> on 2017/11/14 20:13:31 UTC
[GitHub] spark pull request #19749: [SPARK-22519][YARN] Remove unnecessary stagingDir...
GitHub user devaraj-kavali opened a pull request:
https://github.com/apache/spark/pull/19749
[SPARK-22519][YARN] Remove unnecessary stagingDirPath null check in ApplicationMaster.cleanupStagingDir()
## What changes were proposed in this pull request?
Removed the unnecessary stagingDirPath null check in ApplicationMaster.cleanupStagingDir().
## How was this patch tested?
I verified with the existing test cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/devaraj-kavali/spark SPARK-22519
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19749.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19749
----
commit 3edcd73711e2f4bcf3e80afbd0694fd42d380012
Author: Devaraj K <de...@apache.org>
Date: 2017-11-14T20:09:34Z
[SPARK-22519][YARN] Remove unnecessary stagingDirPath null check in
ApplicationMaster.cleanupStagingDir()
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19749: [SPARK-22519][YARN] Remove unnecessary stagingDirPath nu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19749
**[Test build #83861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83861/testReport)** for PR 19749 at commit [`3edcd73`](https://github.com/apache/spark/commit/3edcd73711e2f4bcf3e80afbd0694fd42d380012).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19749: [SPARK-22519][YARN] Remove unnecessary stagingDirPath nu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19749
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19749: [SPARK-22519][YARN] Remove unnecessary stagingDirPath nu...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19749
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19749: [SPARK-22519][YARN] Remove unnecessary stagingDirPath nu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19749
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83861/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19749: [SPARK-22519][YARN] Remove unnecessary stagingDir...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19749
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19749: [SPARK-22519][YARN] Remove unnecessary stagingDirPath nu...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19749
Rather, wasn't think likely intended to be a check on whether the env variable exists?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19749: [SPARK-22519][YARN] Remove unnecessary stagingDirPath nu...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19749
@srowen see discussion in the bug.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19749: [SPARK-22519][YARN] Remove unnecessary stagingDirPath nu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19749
**[Test build #83861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83861/testReport)** for PR 19749 at commit [`3edcd73`](https://github.com/apache/spark/commit/3edcd73711e2f4bcf3e80afbd0694fd42d380012).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19749: [SPARK-22519][YARN] Remove unnecessary stagingDirPath nu...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19749
Merging to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19749: [SPARK-22519][YARN] Remove unnecessary stagingDirPath nu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19749
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org