You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/05/06 08:53:21 UTC
[GitHub] [flink] rmetzger opened a new pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
rmetzger opened a new pull request #15845:
URL: https://github.com/apache/flink/pull/15845
This PR addresses two smaller documentation concerns. The changes to the elastic scaling pages were suggested by @knaufk , the changes on the configuration page by @alpinegizmo and @xintongsong.
I'll adjust the Chinese variants of the docs once the changes have been approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15845:
URL: https://github.com/apache/flink/pull/15845#issuecomment-833357335
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1b449c5732f03f99a95fffa3e6592907222a3a0c (Sat Aug 28 11:17:45 UTC 2021)
**Warnings:**
* Documentation files were touched, but no `docs/content.zh/` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15845:
URL: https://github.com/apache/flink/pull/15845#issuecomment-833372499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147808d63058d8b4216d7dff18c51593387ce3a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "147808d63058d8b4216d7dff18c51593387ce3a4",
"triggerType" : "PUSH"
}, {
"hash" : "1b449c5732f03f99a95fffa3e6592907222a3a0c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1b449c5732f03f99a95fffa3e6592907222a3a0c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 147808d63058d8b4216d7dff18c51593387ce3a4 UNKNOWN
* 1b449c5732f03f99a95fffa3e6592907222a3a0c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #15845:
URL: https://github.com/apache/flink/pull/15845#issuecomment-833372441
Thanks a lot for the fast review. I'll wait for @knaufk's approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15845:
URL: https://github.com/apache/flink/pull/15845#issuecomment-833372499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147808d63058d8b4216d7dff18c51593387ce3a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "147808d63058d8b4216d7dff18c51593387ce3a4",
"triggerType" : "PUSH"
}, {
"hash" : "1b449c5732f03f99a95fffa3e6592907222a3a0c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17625",
"triggerID" : "1b449c5732f03f99a95fffa3e6592907222a3a0c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 147808d63058d8b4216d7dff18c51593387ce3a4 UNKNOWN
* 1b449c5732f03f99a95fffa3e6592907222a3a0c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17625)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15845:
URL: https://github.com/apache/flink/pull/15845#issuecomment-833372499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147808d63058d8b4216d7dff18c51593387ce3a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "147808d63058d8b4216d7dff18c51593387ce3a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 147808d63058d8b4216d7dff18c51593387ce3a4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15845:
URL: https://github.com/apache/flink/pull/15845#issuecomment-833357335
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 147808d63058d8b4216d7dff18c51593387ce3a4 (Thu May 06 08:56:40 UTC 2021)
**Warnings:**
* Documentation files were touched, but no `docs/content.zh/` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] alpinegizmo commented on a change in pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on a change in pull request #15845:
URL: https://github.com/apache/flink/pull/15845#discussion_r627218732
##########
File path: docs/content/docs/deployment/config.md
##########
@@ -34,6 +34,8 @@ The configuration is parsed and evaluated when the Flink processes are started.
The out of the box configuration will use your default Java installation. You can manually set the environment variable `JAVA_HOME` or the configuration key `env.java.home` in `conf/flink-conf.yaml` if you want to manually override the Java runtime to use.
+You can specifiy a different configuration directory location by defining the `FLINK_CONF_DIR` environment variable. For resource-providers which provide non-session deployments, you can specifiy per-job configurations this way. Make a copy of the `conf` directory from the Flink distribution and modify the settings on a per-job basis. Note that this is not supported in Docker or standalone Kubernetes deployments.
Review comment:
What happens if I set FLINK_CONF_DIR when submitting a job to a session cluster?
```suggestion
You can specify a different configuration directory location by defining the `FLINK_CONF_DIR` environment variable. For resource providers which provide non-session deployments, you can specify per-job configurations this way. Make a copy of the `conf` directory from the Flink distribution and modify the settings on a per-job basis. Note that this is not supported in Docker or standalone Kubernetes deployments.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15845:
URL: https://github.com/apache/flink/pull/15845#issuecomment-833372499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147808d63058d8b4216d7dff18c51593387ce3a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "147808d63058d8b4216d7dff18c51593387ce3a4",
"triggerType" : "PUSH"
}, {
"hash" : "1b449c5732f03f99a95fffa3e6592907222a3a0c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17625",
"triggerID" : "1b449c5732f03f99a95fffa3e6592907222a3a0c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 147808d63058d8b4216d7dff18c51593387ce3a4 UNKNOWN
* 1b449c5732f03f99a95fffa3e6592907222a3a0c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17625)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #15845:
URL: https://github.com/apache/flink/pull/15845#discussion_r627227797
##########
File path: docs/content/docs/deployment/config.md
##########
@@ -34,6 +34,8 @@ The configuration is parsed and evaluated when the Flink processes are started.
The out of the box configuration will use your default Java installation. You can manually set the environment variable `JAVA_HOME` or the configuration key `env.java.home` in `conf/flink-conf.yaml` if you want to manually override the Java runtime to use.
+You can specifiy a different configuration directory location by defining the `FLINK_CONF_DIR` environment variable. For resource-providers which provide non-session deployments, you can specifiy per-job configurations this way. Make a copy of the `conf` directory from the Flink distribution and modify the settings on a per-job basis. Note that this is not supported in Docker or standalone Kubernetes deployments.
Review comment:
thanks for the feedback. Looks like something is not correctly wired in my 🧠 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger closed pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #15845:
URL: https://github.com/apache/flink/pull/15845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #15845:
URL: https://github.com/apache/flink/pull/15845#issuecomment-834106375
Thanks for the reviews! Merging ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a change in pull request #15845: [hotfix][docs] Re-introduce note about FLINK_CONF_DIR
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #15845:
URL: https://github.com/apache/flink/pull/15845#discussion_r627225174
##########
File path: docs/content/docs/deployment/config.md
##########
@@ -34,6 +34,8 @@ The configuration is parsed and evaluated when the Flink processes are started.
The out of the box configuration will use your default Java installation. You can manually set the environment variable `JAVA_HOME` or the configuration key `env.java.home` in `conf/flink-conf.yaml` if you want to manually override the Java runtime to use.
+You can specifiy a different configuration directory location by defining the `FLINK_CONF_DIR` environment variable. For resource-providers which provide non-session deployments, you can specifiy per-job configurations this way. Make a copy of the `conf` directory from the Flink distribution and modify the settings on a per-job basis. Note that this is not supported in Docker or standalone Kubernetes deployments.
+
Review comment:
Maybe also mention `FLINK_PROPERTIES` as the alternative in docker/standalone-k8s deployments. This, instead of specifying a different configuration directory, appends given configurations to the flink-conf file in the image.
https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/deployment/resource-providers/standalone/docker/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org