You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/12/19 12:57:48 UTC
[GitHub] tajo pull request: TAJO-1261: Separate query and ddl execution cod...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/312
TAJO-1261: Separate query and ddl execution codes from GlobalEngine.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1261
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #312
----
commit f7e2cd3c706de99d6a2a7d2d2ee69dba28fe3221
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-12-19T11:55:26Z
TAJO-1261: Separate query and ddl execution codes from GlobalEngine.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1261: Separate query and ddl execution cod...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/312#issuecomment-67761407
Sorry @ykrips @hyunsik,
even though +1 is given, I would like to make a trivial suggestion.
I have left some comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1261: Separate query and ddl execution cod...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/312#issuecomment-67759656
Thank you for your comment. If you think that some patch is acceptable, you can give one +1 for the patch. Then, the patch can be committed to a targeted branch. The Apache voting process is described at http://www.apache.org/foundation/voting.html.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1261: Separate query and ddl execution cod...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/312#issuecomment-67804653
Thanks for your understanding.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1261: Separate query and ddl execution cod...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/312#issuecomment-67804360
Hi @jihoonson,
You are right. They can be removed now. In the patch, InsertHook did some special work to rewrite a logical plan. So, the hook was required. But, it doesn't now. I'll remove it and then commit the patch. Thank you for the comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1261: Separate query and ddl execution cod...
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/312#issuecomment-67759947
Thank you for your guide. I need to much be familiar to Apache process.:)
I would like to give +1 to this issue. These two executors might be helpful when we extend functions on global engine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1261: Separate query and ddl execution cod...
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/312#issuecomment-67758348
It is a good work to refactor Global Engine into small chunks of codes. I did not find any issues when running several queries on existing tajo cluster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1261: Separate query and ddl execution cod...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1261: Separate query and ddl execution cod...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/312#discussion_r22146002
--- Diff: tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java ---
@@ -390,8 +392,8 @@ public synchronized void startQuery() {
optimizer.optimize(queryContext, plan);
- GlobalEngine.DistributedQueryHookManager hookManager = new GlobalEngine.DistributedQueryHookManager();
- hookManager.addHook(new GlobalEngine.InsertHook());
+ DistributedQueryHookManager hookManager = new DistributedQueryHookManager();
+ hookManager.addHook(new InsertIntoHook());
--- End diff --
Both QueryExecutor and QueryMasterTask have the DistributedQueryHookManager.
So, it would be better to maintain it in only one module.
Since this is not a big change, I think that we can fix this in this issue.
IMHO, QueryMasterTask is the proper one.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---