You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by ji...@apache.org on 2024/10/11 07:56:39 UTC
(amoro) branch 0.7.x updated: [AMORO-3110] Do not throw exception when retry task in optimizer keeper (#3223)
This is an automated email from the ASF dual-hosted git repository.
jinsongzhou pushed a commit to branch 0.7.x
in repository https://gitbox.apache.org/repos/asf/amoro.git
The following commit(s) were added to refs/heads/0.7.x by this push:
new 50d8a8086 [AMORO-3110] Do not throw exception when retry task in optimizer keeper (#3223)
50d8a8086 is described below
commit 50d8a80868842db962a693bfe68146515177ea03
Author: Xavier Bai <xu...@apache.org>
AuthorDate: Thu Sep 26 17:29:30 2024 +0800
[AMORO-3110] Do not throw exception when retry task in optimizer keeper (#3223)
Do not throw exception when retry task in optimizer keeper
(cherry picked from commit a2bc71ab7360760035b55ade676dcab2d90e6b74)
Signed-off-by: zhoujinsong <zh...@163.com>
---
.../org/apache/amoro/server/DefaultOptimizingService.java | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java b/amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java
index 9e940a801..91fde213c 100644
--- a/amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java
+++ b/amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java
@@ -33,6 +33,7 @@ import org.apache.amoro.api.resource.Resource;
import org.apache.amoro.api.resource.ResourceGroup;
import org.apache.amoro.properties.CatalogMetaProperties;
import org.apache.amoro.server.exception.ForbiddenException;
+import org.apache.amoro.server.exception.IllegalTaskStateException;
import org.apache.amoro.server.exception.ObjectNotExistsException;
import org.apache.amoro.server.exception.PluginRetryAuthException;
import org.apache.amoro.server.exception.TaskNotFoundException;
@@ -148,8 +149,8 @@ public class DefaultOptimizingService extends StatedPersistentBase
.forEach(groupName -> LOG.warn("Unloaded task runtime in group {}", groupName));
}
- private void registerOptimizer(OptimizerInstance optimizer, boolean needPersistency) {
- if (needPersistency) {
+ private void registerOptimizer(OptimizerInstance optimizer, boolean needPersistent) {
+ if (needPersistent) {
doAs(OptimizerMapper.class, mapper -> mapper.insertOptimizer(optimizer));
}
@@ -566,7 +567,14 @@ public class DefaultOptimizingService extends StatedPersistentBase
task.getTaskId(),
task.getResourceDesc());
// optimizing task of suspending optimizer would not be counted for retrying
- queue.retryTask(task);
+ try {
+ queue.retryTask(task);
+ } catch (IllegalTaskStateException e) {
+ LOG.error(
+ "Retry task {} failed due to {}, will check it in next round",
+ task.getTaskId(),
+ e.getMessage());
+ }
}
private Predicate<TaskRuntime> buildSuspendingPredication(Set<String> activeTokens) {