You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Carl Steinbach (JIRA)" <ji...@apache.org> on 2011/01/03 13:56:45 UTC
[jira] Created: (HIVE-1877) Change the name of the reflect() UDF to
java_method()
Change the name of the reflect() UDF to java_method()
-----------------------------------------------------
Key: HIVE-1877
URL: https://issues.apache.org/jira/browse/HIVE-1877
Project: Hive
Issue Type: Improvement
Components: UDF
Reporter: Carl Steinbach
HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
queries. In my opinion the name is confusing since it describes how the UDF works instead of what
it does. I propose changing the name of (or providing a synonym for) the UDF to something like
'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (HIVE-1877) Add java_method() as a synonym for the
reflect() UDF
Posted by "Zhenxiao Luo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-1877:
-------------------------------
Attachment: HIVE-1877.3.patch.txt
Code Review Request for HIVE-1877
> Add java_method() as a synonym for the reflect() UDF
> ----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-1877.1.patch.txt, HIVE-1877.2.patch.txt, HIVE-1877.3.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1877) Add java_method() as a synonym for the
reflect() UDF
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1877:
---------------------------------
Summary: Add java_method() as a synonym for the reflect() UDF (was: Change the name of the reflect() UDF to java_method())
> Add java_method() as a synonym for the reflect() UDF
> ----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Reporter: Carl Steinbach
> Attachments: HIVE-1877.1.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (HIVE-1877) Add java_method() as a synonym for
the reflect() UDF
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175851#comment-13175851 ]
Hudson commented on HIVE-1877:
------------------------------
Integrated in Hive-trunk-h0.23.0 #48 (See [https://builds.apache.org/job/Hive-trunk-h0.23.0/48/])
HIVE-1877. Add java_method() as a synonym for the reflect() UDF (Zhenxiao Luo via cws)
cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1224646
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
* /hive/trunk/ql/src/test/queries/clientpositive/udf_java_method.q
* /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out
* /hive/trunk/ql/src/test/results/clientpositive/udf_java_method.q.out
* /hive/trunk/ql/src/test/results/clientpositive/udf_reflect.q.out
> Add java_method() as a synonym for the reflect() UDF
> ----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Fix For: 0.9.0
>
> Attachments: HIVE-1877.1.patch.txt, HIVE-1877.2.patch.txt, HIVE-1877.3.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1877) Add java_method() as a synonym for the
reflect() UDF
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1877:
---------------------------------
Assignee: Carl Steinbach
Affects Version/s: 0.7.0
Status: Patch Available (was: Open)
Review request: https://reviews.apache.org/r/197/
> Add java_method() as a synonym for the reflect() UDF
> ----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1877.1.patch.txt, HIVE-1877.2.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (HIVE-1877) Add java_method() as a synonym for the
reflect() UDF
Posted by "Carl Steinbach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1877:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.9.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Zhenxiao!
> Add java_method() as a synonym for the reflect() UDF
> ----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Fix For: 0.9.0
>
> Attachments: HIVE-1877.1.patch.txt, HIVE-1877.2.patch.txt, HIVE-1877.3.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-1877) Add java_method() as a synonym for
the reflect() UDF
Posted by "Carl Steinbach (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach reassigned HIVE-1877:
------------------------------------
Assignee: Zhenxiao Luo (was: Carl Steinbach)
> Add java_method() as a synonym for the reflect() UDF
> ----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-1877.1.patch.txt, HIVE-1877.2.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1877) Add java_method() as a synonym for
the reflect() UDF
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175869#comment-13175869 ]
Hudson commented on HIVE-1877:
------------------------------
Integrated in Hive-trunk-h0.21 #1170 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1170/])
HIVE-1877. Add java_method() as a synonym for the reflect() UDF (Zhenxiao Luo via cws)
cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1224646
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
* /hive/trunk/ql/src/test/queries/clientpositive/udf_java_method.q
* /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out
* /hive/trunk/ql/src/test/results/clientpositive/udf_java_method.q.out
* /hive/trunk/ql/src/test/results/clientpositive/udf_reflect.q.out
> Add java_method() as a synonym for the reflect() UDF
> ----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Fix For: 0.9.0
>
> Attachments: HIVE-1877.1.patch.txt, HIVE-1877.2.patch.txt, HIVE-1877.3.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1877) Add java_method() as a synonym for
the reflect() UDF
Posted by "Carl Steinbach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175329#comment-13175329 ]
Carl Steinbach commented on HIVE-1877:
--------------------------------------
+1. Will commit if tests pass.
> Add java_method() as a synonym for the reflect() UDF
> ----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-1877.1.patch.txt, HIVE-1877.2.patch.txt, HIVE-1877.3.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1877) Change the name of the reflect() UDF to
java_method()
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1877:
---------------------------------
Attachment: HIVE-1877.1.patch.txt
> Change the name of the reflect() UDF to java_method()
> -----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Reporter: Carl Steinbach
> Attachments: HIVE-1877.1.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (HIVE-1877) Add java_method() as a synonym for the
reflect() UDF
Posted by "Zhenxiao Luo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-1877:
-------------------------------
Release Note: java_method() is a synonym for reflect()
Status: Patch Available (was: Open)
> Add java_method() as a synonym for the reflect() UDF
> ----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-1877.1.patch.txt, HIVE-1877.2.patch.txt, HIVE-1877.3.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1877) Change the name of the reflect() UDF
to java_method()
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976760#action_12976760 ]
Edward Capriolo commented on HIVE-1877:
---------------------------------------
It is probably easier work wise for us to simply register the UDF with two names. This results in less work. I agree that the name could be better in that regard, but we do not have many UDF's. So you could not convince me because it is a but trivial, but if you are going to do the work I would not block it.
> Change the name of the reflect() UDF to java_method()
> -----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Reporter: Carl Steinbach
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1877) Add java_method() as a synonym for the
reflect() UDF
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HIVE-1877:
------------------------------------------
Status: Open (was: Patch Available)
Patch does not apply cleanly. Can you regenerate? I will run tests and commit, once new patch is uploaded.
> Add java_method() as a synonym for the reflect() UDF
> ----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1877.1.patch.txt, HIVE-1877.2.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1877) Add java_method() as a synonym for the
reflect() UDF
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1877:
---------------------------------
Attachment: HIVE-1877.2.patch.txt
> Add java_method() as a synonym for the reflect() UDF
> ----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Reporter: Carl Steinbach
> Attachments: HIVE-1877.1.patch.txt, HIVE-1877.2.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1877) Add java_method() as a synonym for
the reflect() UDF
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005034#comment-13005034 ]
Amareshwari Sriramadasu commented on HIVE-1877:
-----------------------------------------------
+1 Patch looks good
> Add java_method() as a synonym for the reflect() UDF
> ----------------------------------------------------
>
> Key: HIVE-1877
> URL: https://issues.apache.org/jira/browse/HIVE-1877
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1877.1.patch.txt, HIVE-1877.2.patch.txt
>
>
> HIVE-471 added the reflect() UDF which allows people to invoke static Java methods from within HQL
> queries. In my opinion the name is confusing since it describes how the UDF works instead of what
> it does. I propose changing the name of (or providing a synonym for) the UDF to something like
> 'invoke_method' or 'java_method', or something similar. I'm open to suggestions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira