You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by za...@apache.org on 2025/02/12 02:27:36 UTC
(flink) branch master updated: [FLINK-37301][state/forst] Fix wrong flag returned by `ForStStateBackend#supportsSavepointFormat` (#26143)
This is an automated email from the ASF dual-hosted git repository.
zakelly pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new 62c0899f48e [FLINK-37301][state/forst] Fix wrong flag returned by `ForStStateBackend#supportsSavepointFormat` (#26143)
62c0899f48e is described below
commit 62c0899f48e831a0510a6e030bcc5c8fd15830b5
Author: Zakelly <za...@gmail.com>
AuthorDate: Wed Feb 12 10:27:29 2025 +0800
[FLINK-37301][state/forst] Fix wrong flag returned by `ForStStateBackend#supportsSavepointFormat` (#26143)
---
.../java/org/apache/flink/state/forst/ForStStateBackend.java | 10 +++++++++-
.../apache/flink/state/forst/ForStStateBackendConfigTest.java | 8 ++++++++
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStStateBackend.java b/flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStStateBackend.java
index 105b213b94e..5d9b3d69ab7 100644
--- a/flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStStateBackend.java
+++ b/flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStStateBackend.java
@@ -29,6 +29,7 @@ import org.apache.flink.configuration.IllegalConfigurationException;
import org.apache.flink.configuration.ReadableConfig;
import org.apache.flink.configuration.description.InlineElement;
import org.apache.flink.core.execution.RecoveryClaimMode;
+import org.apache.flink.core.execution.SavepointFormatType;
import org.apache.flink.core.fs.Path;
import org.apache.flink.metrics.MetricGroup;
import org.apache.flink.runtime.execution.Environment;
@@ -636,11 +637,18 @@ public class ForStStateBackend extends AbstractManagedMemoryStateBackend
return optionsFactory;
}
- /** Both ForStSyncKeyedStateBackend and ForStKeyedStateBackend support no claim mode. */
+ @Override
public boolean supportsNoClaimRestoreMode() {
+ // Both ForStSyncKeyedStateBackend and ForStKeyedStateBackend support no claim mode.
return true;
}
+ @Override
+ public boolean supportsSavepointFormat(SavepointFormatType formatType) {
+ // We only support native format for now.
+ return formatType == SavepointFormatType.NATIVE;
+ }
+
// ------------------------------------------------------------------------
// Parameters
// ------------------------------------------------------------------------
diff --git a/flink-state-backends/flink-statebackend-forst/src/test/java/org/apache/flink/state/forst/ForStStateBackendConfigTest.java b/flink-state-backends/flink-statebackend-forst/src/test/java/org/apache/flink/state/forst/ForStStateBackendConfigTest.java
index 91183e551c9..cd94283963d 100644
--- a/flink-state-backends/flink-statebackend-forst/src/test/java/org/apache/flink/state/forst/ForStStateBackendConfigTest.java
+++ b/flink-state-backends/flink-statebackend-forst/src/test/java/org/apache/flink/state/forst/ForStStateBackendConfigTest.java
@@ -26,6 +26,7 @@ import org.apache.flink.configuration.Configuration;
import org.apache.flink.configuration.CoreOptions;
import org.apache.flink.configuration.MemorySize;
import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.core.execution.SavepointFormatType;
import org.apache.flink.core.fs.CloseableRegistry;
import org.apache.flink.core.fs.FileSystem;
import org.apache.flink.core.fs.Path;
@@ -771,6 +772,13 @@ public class ForStStateBackendConfigTest {
}
}
+ @Test
+ public void testSupportSavepoint() {
+ ForStStateBackend forStStateBackend = new ForStStateBackend();
+ assertFalse(forStStateBackend.supportsSavepointFormat(SavepointFormatType.CANONICAL));
+ assertTrue(forStStateBackend.supportsSavepointFormat(SavepointFormatType.NATIVE));
+ }
+
private void verifySetParameter(Runnable setter) {
try {
setter.run();