You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by rj...@gmail.com on 2013/04/08 00:27:18 UTC
Review Request: Sqoop2: Show connection and job command hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10331/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
Show connection and job command hung when connection or job records size more than 8.
Problem while invoking prepareStatement method.
This addresses bug sqoop-980.
https://issues.apache.org/jira/browse/sqoop-980
Diffs
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 486635d
Diff: https://reviews.apache.org/r/10331/diff/
Testing
-------
Done
Thanks,
vasanthkumar
Re: Review Request: Sqoop2: Show connection and job command hung
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10331/#review19131
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On April 13, 2013, 8:53 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10331/
> -----------------------------------------------------------
>
> (Updated April 13, 2013, 8:53 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Show connection and job command hung when connection or job records size more than 8.
> Problem while invoking prepareStatement method.
>
>
> This addresses bug sqoop-980.
> https://issues.apache.org/jira/browse/sqoop-980
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 486635d
>
> Diff: https://reviews.apache.org/r/10331/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>
Re: Review Request: Sqoop2: Show connection and job command hung
Posted by rj...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10331/
-----------------------------------------------------------
(Updated April 13, 2013, 8:53 p.m.)
Review request for Sqoop.
Changes
-------
Implemented Jarek's suggestion.
Description
-------
Show connection and job command hung when connection or job records size more than 8.
Problem while invoking prepareStatement method.
This addresses bug sqoop-980.
https://issues.apache.org/jira/browse/sqoop-980
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 486635d
Diff: https://reviews.apache.org/r/10331/diff/
Testing
-------
Done
Thanks,
vasanthkumar
Re: Review Request: Sqoop2: Show connection and job command hung
Posted by rj...@gmail.com.
> On April 13, 2013, 6:56 p.m., Jarek Cecho wrote:
> > Hi Vasanth,
> > thank you very much for catching this one. We're clearly not properly closing all opened statements. It seems that we're creating the PreparedStatements inside the while loop which seems quite inefficient. What about creating the statements outside of the while loop and reuse them?
> >
> > Jarcec
yes we can resue them.
- vasanthkumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10331/#review19126
-----------------------------------------------------------
On April 7, 2013, 10:27 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10331/
> -----------------------------------------------------------
>
> (Updated April 7, 2013, 10:27 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Show connection and job command hung when connection or job records size more than 8.
> Problem while invoking prepareStatement method.
>
>
> This addresses bug sqoop-980.
> https://issues.apache.org/jira/browse/sqoop-980
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 486635d
>
> Diff: https://reviews.apache.org/r/10331/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>
Re: Review Request: Sqoop2: Show connection and job command hung
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10331/#review19126
-----------------------------------------------------------
Hi Vasanth,
thank you very much for catching this one. We're clearly not properly closing all opened statements. It seems that we're creating the PreparedStatements inside the while loop which seems quite inefficient. What about creating the statements outside of the while loop and reuse them?
Jarcec
- Jarek Cecho
On April 7, 2013, 10:27 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10331/
> -----------------------------------------------------------
>
> (Updated April 7, 2013, 10:27 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Show connection and job command hung when connection or job records size more than 8.
> Problem while invoking prepareStatement method.
>
>
> This addresses bug sqoop-980.
> https://issues.apache.org/jira/browse/sqoop-980
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 486635d
>
> Diff: https://reviews.apache.org/r/10331/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>