You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/31 16:16:07 UTC

[GitHub] seancxmao commented on issue #23224: [SPARK-26277][SQL][TEST] WholeStageCodegen metrics should be tested with whole-stage codegen enabled

seancxmao commented on issue #23224: [SPARK-26277][SQL][TEST] WholeStageCodegen metrics should be tested with whole-stage codegen enabled
URL: https://github.com/apache/spark/pull/23224#issuecomment-450663758
 
 
   Because #23258 has got merged, so I made changes to use `testSparkPlanMetricsWithPredicates` introduced in #23258 to check `WholeStageCodegen` metrics in a more reasonable way.
   
   @srowen @mgaido91 Would you please take a look at this if you have time?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org