You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/04/01 23:33:41 UTC

Review Request 32743: DRILL-2651: Increase some JDBC tests' timeout time.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32743/
-----------------------------------------------------------

Review request for drill and Parth Chandra.


Bugs: DRILL-2651
    https://issues.apache.org/jira/browse/DRILL-2651


Repository: drill-git


Description
-------

Added overriding timeout rule for test that have been timing out increasingly:
- TestJdbcMetadata
- Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest


Diffs
-----

  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.java faca543 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcMetadata.java 24372a7 

Diff: https://reviews.apache.org/r/32743/diff/


Testing
-------

Ran tests several times.  Saw that timeouts that had been appearing in unit tests seem to have stopped.


Thanks,

Daniel Barclay


Re: Review Request 32743: DRILL-2651: Increase some JDBC tests' timeout time.

Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32743/#review78732
-----------------------------------------------------------

Ship it!


Ship It!

- Parth Chandra


On April 1, 2015, 9:33 p.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32743/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 9:33 p.m.)
> 
> 
> Review request for drill and Parth Chandra.
> 
> 
> Bugs: DRILL-2651
>     https://issues.apache.org/jira/browse/DRILL-2651
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Added overriding timeout rule for test that have been timing out increasingly:
> - TestJdbcMetadata
> - Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest
> 
> 
> Diffs
> -----
> 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.java faca543 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcMetadata.java 24372a7 
> 
> Diff: https://reviews.apache.org/r/32743/diff/
> 
> 
> Testing
> -------
> 
> Ran tests several times.  Saw that timeouts that had been appearing in unit tests seem to have stopped.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>