You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/17 03:37:01 UTC

[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1061: [SEATUNNEL#1060] Enable the MagicNumber rule in checkstyle and fix them

CalvinKirs commented on a change in pull request #1061:
URL: https://github.com/apache/incubator-seatunnel/pull/1061#discussion_r785616858



##########
File path: seatunnel-connectors/seatunnel-connector-flink-doris/src/main/java/org/apache/seatunnel/flink/sink/DorisOutputFormat.java
##########
@@ -44,6 +44,7 @@
  **/
 public class DorisOutputFormat<T> extends RichOutputFormat<T> {
     private static final Logger LOGGER = LoggerFactory.getLogger(DorisSinkFunction.class);
+    private static final long DEFAULT_INTERVAL_MS = TimeUnit.MINUTES.toMillis(1);
     private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();

Review comment:
       Why expand this value?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org