[jclouds] disable directory blob tests in OS X (#640)

[Ka-Hing Cheung <no...@github.com>]

On OS X, java doesn't support xattrs, which is required by
directory blobs. Disable those tests on OS X

should fix @jdaggett 's problem with #637 
You can merge this Pull Request by running:

  git pull https://github.com/kahing/jclouds filesystem-directory-blobs

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/640

-- Commit Summary --

  * support directory blobs
  * disable directory blob tests in OS X

-- File Changes --

    M apis/filesystem/src/main/java/org/jclouds/filesystem/predicates/validators/internal/FilesystemBlobKeyValidatorImpl.java (5)
    M apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java (142)
    M apis/filesystem/src/test/java/org/jclouds/filesystem/FilesystemBlobStoreTest.java (61)
    M apis/filesystem/src/test/java/org/jclouds/filesystem/predicates/validators/internal/FilesystemBlobKeyValidatorTest.java (5)
    M apis/filesystem/src/test/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImplTest.java (67)
    M blobstore/src/main/java/org/jclouds/blobstore/config/LocalBlobStore.java (21)
    M blobstore/src/main/java/org/jclouds/blobstore/reference/BlobStoreConstants.java (1)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/640.patch
https://github.com/jclouds/jclouds/pull/640.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/640

Re: [jclouds] disable directory blob tests in OS X (#640)

[Andrew Gaul <no...@github.com>]

Pushed to master as 5cc3b243fc878a44091b78b14d8e5cb00086a75a.

This commit addresses the test failures, although we might need a more general solution.  Unfortunately lack of extended attributes on Mac OS X is a [JDK issue](https://bugs.openjdk.java.net/browse/JDK-8030048).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/640#issuecomment-69642878

Re: [jclouds] disable directory blob tests in OS X (#640)

[Jeremy Daggett <no...@github.com>]

@kahing @andrewgaul After pulling this commit and running the tests again, I am getting two new failures :confused: :
```
Failed tests:
  FilesystemBlobIntegrationTest>BaseBlobIntegrationTest.testPutByteSource:531->BaseBlobIntegrationTest.testPut:584
Expecting:
 <{}>
to be equal to:
 <{"key1"="value1", "key2"="value2"}>
but was not.
  FilesystemBlobIntegrationTest>BaseBlobIntegrationTest.testPutInputStream:539->BaseBlobIntegrationTest.testPut:584
Expecting:
 <{}>
to be equal to:
 <{"key1"="value1", "key2"="value2"}>
but was not.
```

Any insight is appreciated, thx!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/640#issuecomment-69770173

Re: [jclouds] disable directory blob tests in OS X (#640)

[Jeremy Daggett <no...@github.com>]

We should skip those additional two tests as well. I will submit a PR shortly with the changes, thx!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/640#issuecomment-69775234

Re: [jclouds] disable directory blob tests in OS X (#640)

[Jeremy Daggett <no...@github.com>]

@kahing Thanks for the fix! This is exactly how I worked around the issue earlier this morning. As soon as the build succeeds, I am +1 for this PR. cc/ @andrewgaul 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/640#issuecomment-69632506