You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/05 16:40:00 UTC

[jira] [Commented] (GROOVY-8422) Incorrect properties copy in Sql.newInstance

    [ https://issues.apache.org/jira/browse/GROOVY-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386313#comment-16386313 ] 

ASF GitHub Bot commented on GROOVY-8422:
----------------------------------------

GitHub user jwagenleitner opened a pull request:

    https://github.com/apache/groovy/pull/671

    GROOVY-8422: Incorrect properties copy in Sql.newInstance

    The provided Properties should be passed to the DriverManager as-is.
    A copy is only needed when changes are made to the provided Properties
    in order to mask sensitive information for logging purposes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwagenleitner/groovy 8422-sql-props

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #671
    
----
commit 1f833b4af4e5e5ac667967b55f279e9534d5ec58
Author: John Wagenleitner <jw...@...>
Date:   2018-03-05T16:35:33Z

    GROOVY-8422: Incorrect properties copy in Sql.newInstance
    
    The provided Properties should be passed to the DriverManager as-is.
    A copy is only needed when changes are made to the provided Properties
    in order to mask sensitive information for logging purposes.

----


> Incorrect properties copy in Sql.newInstance 
> ---------------------------------------------
>
>                 Key: GROOVY-8422
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8422
>             Project: Groovy
>          Issue Type: Bug
>          Components: SQL processing
>    Affects Versions: 2.4.13
>            Reporter: Thomas Weise
>            Priority: Major
>
> The constructor `Properties(Properties defaults)` does not create a copy, but a new object with the argument as defaults. That breaks JDBC drivers that expect the properties to be present in the object directly (enumerating of keys, containsKey etc.).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)