You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-users@xalan.apache.org by Mukul Gandhi <mu...@apache.org> on 2022/12/10 10:12:53 UTC
[request to review, and vote] XalanJ 2.7.3 release candidate RC6
Hi all,
We've published the new RC for XalanJ 2.7.3 release (located at
https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC6/). This RC,
uses Commons BCEL 6.7.0, and has few minor improvements to the XalanJ
build script.
The tag corresponding to this RC, is xalan-j_2_7_3-rc6 and has been
committed as well.
The necessary XalanJ build tests pass, with this RC.
The key used to sign this RC is located within the file, at
https://dlcdn.apache.org/xalan/xalan-j/KEYS.
Please review this release candidate and vote.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Great work everyone. Here's my +1 for this RC.
--
Regards,
Mukul Gandhi
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Mukul Gandhi <mu...@apache.org>.
Hi Vladimir,
On Sat, Dec 24, 2022 at 3:18 PM Vladimir Sitnikov
<si...@gmail.com> wrote:
>
> Thanks for the effort on releasing XalanJ, however, I wonder if re-organizing tests should really block the release.
IMHO, I don't think so. re-organizing XalanJ tests has worked fine I
believe (the only change is, providing XalanJ source distribution
users, the means to run XalanJ tests from source distribution itself),
as per review comments by Gary during this XalanJ 2.7.3 release
process.
I do hope, to publish XalanJ 2.7.3 RC7 after a short while, that can
then be reviewed.
--
Regards,
Mukul Gandhi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Vladimir Sitnikov <si...@gmail.com>.
Thanks for the effort on releasing XalanJ, however, I wonder if
re-organizing tests should really block the release.
Unfortunately, there's a published CVE, and bad actors might exploit it.
So I would suggest releasing XalanJ with the minimal changes possible to
ease the upgrade for everybody, and then refactor the test code.
Vladimir
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Mukul Gandhi <mu...@apache.org>.
Hi Gary & all,
I'd like to try make an RC7, for the XalanJ 2.7.3 release. XalanJ
2.7.3 RC7 shall include, a change whereby XalanJ source distribution
users can make XalanJ build and also run tests as well. As part of
XalanJ 2.7.3 RC7, we'll also have a readme file within source
distribution as well.
I'll share the details about XalanJ 2.7.3 RC7, on XalanJ lists, when
that is ready to be reviewed.
Many thanks.
On Wed, Dec 21, 2022 at 7:02 PM Gary Gregory <ga...@gmail.com> wrote:
>
> Sorry for the late reply, I will try to get to it later today or tonight.
>
> Gary
--
Regards,
Mukul Gandhi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Gary Gregory <ga...@gmail.com>.
Sorry for the late reply, I will try to get to it later today or tonight.
Gary
On Wed, Dec 21, 2022, 07:31 Mukul Gandhi <mu...@apache.org> wrote:
> Hi Gary,
> As per mails referred below, would you like to verify these XalanJ
> build codebase changes, by looking/trying by pulling and testing the
> codebase from relevant XalanJ repos?
>
> Or, shall we create a new XalanJ 2.7.3 RC, that you all could verify?
>
> On Sun, Dec 18, 2022 at 6:13 AM Gary Gregory <ga...@gmail.com>
> wrote:
> >
> > Thanks for the update.
> > I'll should be able to take a look tomorrow.
> >
> > Gary
> >
> > On Sat, Dec 17, 2022, 19:19 Mukul Gandhi <mu...@apache.org> wrote:
> >>
> >> Hi Gary,
> >> We've implemented latest changes, as discussed within this thread,
> >> to few of XalanJ 2.7.3 release build file(s). With everything else
> >> remaining same, for the XalanJ and its tests codebase, the new commits
> >> pushed by us now allow us, to build properly XalanJ and also run its
> >> tests from the XalanJ source distribution.
> >>
> >> It'll be nice, if you or anyone else may take latest changes from
> >> XalanJ codebase and tests repos, and verify that, these modifications
> >> have been done correctly. After which, we could prepare a new XalanJ
> >> 2.7.3 RC.
>
>
> --
> Regards,
> Mukul Gandhi
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
> For additional commands, e-mail: dev-help@xalan.apache.org
>
>
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Mukul Gandhi <mu...@apache.org>.
Hi Gary,
As per mails referred below, would you like to verify these XalanJ
build codebase changes, by looking/trying by pulling and testing the
codebase from relevant XalanJ repos?
Or, shall we create a new XalanJ 2.7.3 RC, that you all could verify?
On Sun, Dec 18, 2022 at 6:13 AM Gary Gregory <ga...@gmail.com> wrote:
>
> Thanks for the update.
> I'll should be able to take a look tomorrow.
>
> Gary
>
> On Sat, Dec 17, 2022, 19:19 Mukul Gandhi <mu...@apache.org> wrote:
>>
>> Hi Gary,
>> We've implemented latest changes, as discussed within this thread,
>> to few of XalanJ 2.7.3 release build file(s). With everything else
>> remaining same, for the XalanJ and its tests codebase, the new commits
>> pushed by us now allow us, to build properly XalanJ and also run its
>> tests from the XalanJ source distribution.
>>
>> It'll be nice, if you or anyone else may take latest changes from
>> XalanJ codebase and tests repos, and verify that, these modifications
>> have been done correctly. After which, we could prepare a new XalanJ
>> 2.7.3 RC.
--
Regards,
Mukul Gandhi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Gary Gregory <ga...@gmail.com>.
Thanks for the update.
I'll should be able to take a look tomorrow.
Gary
On Sat, Dec 17, 2022, 19:19 Mukul Gandhi <mu...@apache.org> wrote:
> Hi Gary,
> We've implemented latest changes, as discussed within this thread,
> to few of XalanJ 2.7.3 release build file(s). With everything else
> remaining same, for the XalanJ and its tests codebase, the new commits
> pushed by us now allow us, to build properly XalanJ and also run its
> tests from the XalanJ source distribution.
>
> It'll be nice, if you or anyone else may take latest changes from
> XalanJ codebase and tests repos, and verify that, these modifications
> have been done correctly. After which, we could prepare a new XalanJ
> 2.7.3 RC.
>
> On Mon, Dec 12, 2022 at 9:00 AM Gary Gregory <ga...@gmail.com>
> wrote:
> >
> > That all sounds good to me.
> >
> > Thanks Mukul!
> >
> > Gary
>
>
> --
> Regards,
> Mukul Gandhi
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
> For additional commands, e-mail: dev-help@xalan.apache.org
>
>
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Mukul Gandhi <mu...@apache.org>.
Hi Gary,
We've implemented latest changes, as discussed within this thread,
to few of XalanJ 2.7.3 release build file(s). With everything else
remaining same, for the XalanJ and its tests codebase, the new commits
pushed by us now allow us, to build properly XalanJ and also run its
tests from the XalanJ source distribution.
It'll be nice, if you or anyone else may take latest changes from
XalanJ codebase and tests repos, and verify that, these modifications
have been done correctly. After which, we could prepare a new XalanJ
2.7.3 RC.
On Mon, Dec 12, 2022 at 9:00 AM Gary Gregory <ga...@gmail.com> wrote:
>
> That all sounds good to me.
>
> Thanks Mukul!
>
> Gary
--
Regards,
Mukul Gandhi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Gary Gregory <ga...@gmail.com>.
That all sounds good to me.
Thanks Mukul!
Gary
On Sun, Dec 11, 2022, 19:34 Mukul Gandhi <mu...@apache.org> wrote:
> Hi Gary,
> Thanks for the thoughts.
>
> On Sun, 11 Dec, 2022, 18:45 Gary Gregory, <ga...@gmail.com> wrote:
>
>>
>> The information that is now in this email thread works today, almost,
>> you'd need to say not only "clone repo xalan-test" but "clone repo
>> xalan-test at commit foo", otherwise, the commits in the test repo
>> beyond today could cause someone trying to build from the src zip/tar
>> failures. This is why it makes sense to copy all of xalan-test into
>> xalan-java and put xalan-test into the attic IMO.
>
>
> For the XalanJ 2.7.3 release, and for now, I'm thinking to have xalan-test
> repos as it is and shall put that folder (excluding the .git folder) into
> the src distribution at the time of running the XalanJ "build clean
> fulldist" command. I'll also need to make few minor changes to, build.bat
> and build.xml files that'll go into xalan-test folder of the src
> distribution, that I believe shall be needed by users of src distribution
> to run XalanJ tests.
>
> I'll post the new XalanJ RC, on this list with above mentioned changes,
> asap.
>
> I also believe that, we should not move xalan-test repos to attic as of
> now. That repos, seems to contain lots of information that we might need in
> future with respect to XalanJ project.
>
> I also think that, we should create a tag for xalan-test repos as well (as
> we do for the xalan-java repos), while creating XalanJ RC. I'll be doing
> that as well.
>
>
> --
> Regards,
> Mukul Gandhi
>
>>
>
>
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Mukul Gandhi <mu...@apache.org>.
Hi Gary,
Thanks for the thoughts.
On Sun, 11 Dec, 2022, 18:45 Gary Gregory, <ga...@gmail.com> wrote:
>
> The information that is now in this email thread works today, almost,
> you'd need to say not only "clone repo xalan-test" but "clone repo
> xalan-test at commit foo", otherwise, the commits in the test repo
> beyond today could cause someone trying to build from the src zip/tar
> failures. This is why it makes sense to copy all of xalan-test into
> xalan-java and put xalan-test into the attic IMO.
For the XalanJ 2.7.3 release, and for now, I'm thinking to have xalan-test
repos as it is and shall put that folder (excluding the .git folder) into
the src distribution at the time of running the XalanJ "build clean
fulldist" command. I'll also need to make few minor changes to, build.bat
and build.xml files that'll go into xalan-test folder of the src
distribution, that I believe shall be needed by users of src distribution
to run XalanJ tests.
I'll post the new XalanJ RC, on this list with above mentioned changes,
asap.
I also believe that, we should not move xalan-test repos to attic as of
now. That repos, seems to contain lots of information that we might need in
future with respect to XalanJ project.
I also think that, we should create a tag for xalan-test repos as well (as
we do for the xalan-java repos), while creating XalanJ RC. I'll be doing
that as well.
--
Regards,
Mukul Gandhi
>
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Gary Gregory <ga...@gmail.com>.
Whether or not to recast the RC depends on how much easier we want to
make it to use the end product. I'll let you decide. For my purposes
as a reviewer, I want in one place, the information and data needed to
not only build but also validate the sources. In one place can either
mean, in one repo, or in this email thread.
The information that is now in this email thread works today, almost,
you'd need to say not only "clone repo xalan-test" but "clone repo
xalan-test at commit foo", otherwise, the commits in the test repo
beyond today could cause someone trying to build from the src zip/tar
failures. This is why it makes sense to copy all of xalan-test into
xalan-java and put xalan-test into the attic IMO.
All of that said, it is still possible to get away with the current
vote thread with the addition of the xalan-test commit information. Up
to you ;-)
Gary
On Sun, Dec 11, 2022 at 7:09 AM Mukul Gandhi <mu...@apache.org> wrote:
>
> Hi Gary,
>
> On Sat, Dec 10, 2022 at 5:53 PM Gary D. Gregory <gg...@apache.org> wrote:
>
> > The src zip does not have a readme file or anything that tells a user how to build, test, and validate that what they are building is useful or correct. Would you list this here please?
>
> I guess, we can make available the whole of xalan-test folder (i.e,
> which shall have all the contents of xalan-test repos from the master
> branch, excluding the .git folder), within the src.zip and src.tar.gz
> source distribution files. This can occur, when we'll run the command
> "build clean fulldist" to prepare the XalanJ build. I believe that,
> this shall achieve the desired purpose as written within your mail
> above. We can also, prepare a relevant readme file about how to build
> and do the tests for users of XalanJ source distribution, that we can
> bundle along with the XalanJ src distribution.
>
> Please confirm, whether you find the above steps ok, and then we could
> prepare a new XalanJ 2.7.3 RC.
>
>
> --
> Regards,
> Mukul Gandhi
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
> For additional commands, e-mail: dev-help@xalan.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Mukul Gandhi <mu...@apache.org>.
Hi Gary,
On Sat, Dec 10, 2022 at 5:53 PM Gary D. Gregory <gg...@apache.org> wrote:
> The src zip does not have a readme file or anything that tells a user how to build, test, and validate that what they are building is useful or correct. Would you list this here please?
I guess, we can make available the whole of xalan-test folder (i.e,
which shall have all the contents of xalan-test repos from the master
branch, excluding the .git folder), within the src.zip and src.tar.gz
source distribution files. This can occur, when we'll run the command
"build clean fulldist" to prepare the XalanJ build. I believe that,
this shall achieve the desired purpose as written within your mail
above. We can also, prepare a relevant readme file about how to build
and do the tests for users of XalanJ source distribution, that we can
bundle along with the XalanJ src distribution.
Please confirm, whether you find the above steps ok, and then we could
prepare a new XalanJ 2.7.3 RC.
--
Regards,
Mukul Gandhi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Mukul Gandhi <mu...@apache.org>.
Hi Gary & all,
There was minor typo, within my previous mail.
The corrections are mentioned below please,
To run XalanJ tests from folders, when users extract the files
xalan-j_2_7_3-src.zip or xalan-j_2_7_3-src.tar.gz, users need to
consult the readme file located at
https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint
[1] that has instructions about how *to* run XalanJ tests.
--
Regards,
Mukul Gandhi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by Mukul Gandhi <mu...@apache.org>.
Hi Gary,
On Sat, Dec 10, 2022 at 5:53 PM Gary D. Gregory <gg...@apache.org> wrote:
>
> The src zip does not have a readme file or anything that tells a user how to build, test, and validate that what they are building is useful or correct. Would you list this here please?
>
> Right now, doing 'mvn minitest' and 'build smoketest' says:
>
> minitest-run:
>
> tests-not-available:
> [echo] [tests] The tests do not seem to be present in ../xalan-test
I believe that, XalanJ tests should not be run from the XalanJ sources
location (i.e from within xalan-java repos at the branch
xalan-j_2_7_1_maint and having this somewhere on local environment, or
via the XalanJ source distribution folder that users shall get by
extracting xalan-j_2_7_3-src.zip or xalan-j_2_7_3-src.tar.gz).
To run XalanJ tests from folders, when users extract the files
xalan-j_2_7_3-src.zip or xalan-j_2_7_3-src.tar.gz, users need to
consult the readme file located at
https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint
[1] that has instructions about how run XalanJ tests.
We do provide, the file "testxsl.jar" (at path lib/testxsl.jar) and
the fully populated folder "tests" (at the root of XalanJ source
distribution) within XalanJ source distribution, which are only for
user's information and convenience. I believe that, this is done as
per feedback that we received during one of an earlier mails within
this topic.
I believe that, the issues that you've raised within your mail above
(though they're valid technical points), should not be show stoppers
for making XalanJ 2.7.3 release.
You and others, should please review the XalanJ 2.7.3 RC6 further, if
its good enough to pass for the XalanJ 2.7.3 release. Any comments
about my points mentioned above, and any further feedback about this
topic is most welcome.
--
Regards,
Mukul Gandhi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org
Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC6
Posted by "Gary D. Gregory" <gg...@apache.org>.
The src zip does not have a readme file or anything that tells a user how to build, test, and validate that what they are building is useful or correct. Would you list this here please?
Right now, doing 'mvn minitest' and 'build smoketest' says:
minitest-run:
tests-not-available:
[echo] [tests] The tests do not seem to be present in ../xalan-test
[echo] [tests] You must have checked out from CVS to run the tests,
[echo] [tests] it is not included in binary distributions.
[echo] [tests] See http://xml.apache.org/xalan-j/test/ for more info.
minitest:
BUILD SUCCESSFUL
We need a recipe for validation (IMO).
Gary
On 2022/12/10 10:12:53 Mukul Gandhi wrote:
> Hi all,
> We've published the new RC for XalanJ 2.7.3 release (located at
> https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC6/). This RC,
> uses Commons BCEL 6.7.0, and has few minor improvements to the XalanJ
> build script.
>
> The tag corresponding to this RC, is xalan-j_2_7_3-rc6 and has been
> committed as well.
>
> The necessary XalanJ build tests pass, with this RC.
>
> The key used to sign this RC is located within the file, at
> https://dlcdn.apache.org/xalan/xalan-j/KEYS.
>
> Please review this release candidate and vote.
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Great work everyone. Here's my +1 for this RC.
>
>
> --
> Regards,
> Mukul Gandhi
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
> For additional commands, e-mail: dev-help@xalan.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org