You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2015/09/21 19:49:41 UTC
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1160
[FLINK-2479] Refactor runtime.operators.* tests
This PR refactors most runtime.operators tests to use the TupleGenerator introduced in FLINK-2105.
The changes made can generally be summed up as replacing usages of Records with Tuple2<Integer, String> and adjusting serializers/comparators accordingly. I've added a few static helper methods to the TestData class to simplify comparator/serializer(factory) creation.
One oddball change is the introduction of a separate IntPairComparator whose hash() implementation uses the underlying IntComparators hash() method, to be in line with the TupleComparators implementation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 2479_testdata_pr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1160
----
commit d090d36117694d76850ad2b8cb05b19f57beb3c6
Author: zentol <s....@web.de>
Date: 2015-09-20T17:10:26Z
[FLINK-2479] Refactor runtime.operators.* tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1160#issuecomment-145907305
Hi @zentol, thanks for this effort!
I found a few classes that could be renamed as well. Otherwise, the PR looks good.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1160#issuecomment-142888437
I will shortly add another commit that removes the remaining Record portions in the TestData class and refactors its usages. Originally i planned a separate PR for those, but it took a lot less time than expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280840
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/NonReusingHashMatchIteratorITCase.java ---
@@ -528,31 +521,29 @@ public void testBuildSecondWithMixedDataTypes() {
return map;
}
- static Map<TestData.Key, Collection<RecordIntPairMatch>> matchRecordIntPairValues(
+ static Map<Integer, Collection<RecordIntPairMatch>> matchRecordIntPairValues(
--- End diff --
matchTupleIntPairValues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280897
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/NonReusingHashMatchIteratorITCase.java ---
@@ -498,15 +491,15 @@ public void testBuildSecondWithMixedDataTypes() {
- static Map<TestData.Key, Collection<RecordMatch>> matchRecordValues(
- Map<TestData.Key, Collection<TestData.Value>> leftMap,
- Map<TestData.Key, Collection<TestData.Value>> rightMap)
+ static Map<Integer, Collection<RecordMatch>> matchRecordValues(
--- End diff --
matchSecondTupleFields
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280660
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/NonReusingHashMatchIteratorITCase.java ---
@@ -663,21 +654,21 @@ public String toString() {
}
}
- static final class RecordMatchRemovingJoin extends JoinFunction
+ static final class RecordMatchRemovingJoin implements FlatJoinFunction<Tuple2<Integer, String>, Tuple2<Integer, String>, Tuple2<Integer, String>>
--- End diff --
TupleMatchRemovingJoin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1160#issuecomment-147763784
I've renamed the classes and rebased the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280793
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/NonReusingHashMatchIteratorITCase.java ---
@@ -562,21 +553,21 @@ public void testBuildSecondWithMixedDataTypes() {
}
- static Map<TestData.Key, Collection<TestData.Value>> collectRecordData(MutableObjectIterator<Record> iter)
+ static Map<Integer, Collection<String>> collectRecordData(MutableObjectIterator<Tuple2<Integer, String>> iter)
--- End diff --
collectTupleData
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41279378
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java ---
@@ -663,20 +656,20 @@ public String toString() {
}
}
- static final class RecordMatchRemovingJoin extends JoinFunction
+ static final class RecordMatchRemovingJoin implements FlatJoinFunction<Tuple2<Integer, String>, Tuple2<Integer, String>, Tuple2<Integer, String>>
--- End diff --
TupleMatchRemovingJoin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280171
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java ---
@@ -735,33 +728,31 @@ public void setReference(IntPair reference) {
}
@Override
- public boolean equalToReference(Record candidate) {
+ public boolean equalToReference(Tuple2<Integer, String> candidate) {
try {
- final IntValue i = candidate.getField(0, IntValue.class);
- return i.getValue() == this.reference;
+ return candidate.f0 == this.reference;
} catch (NullPointerException npex) {
throw new NullKeyFieldException();
}
}
@Override
- public int compareToReference(Record candidate) {
+ public int compareToReference(Tuple2<Integer, String> candidate) {
try {
- final IntValue i = candidate.getField(0, IntValue.class);
- return i.getValue() - this.reference;
+ return candidate.f0 - this.reference;
} catch (NullPointerException npex) {
throw new NullKeyFieldException();
}
}
}
- static final class RecordIntPairPairComparator extends TypePairComparator<Record, IntPair>
+ static final class RecordIntPairPairComparator extends TypePairComparator<Tuple2<Integer, String>, IntPair>
--- End diff --
TupleIntPairPairComparator
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41279806
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java ---
@@ -528,18 +521,18 @@ public void testBuildSecondWithMixedDataTypes() {
return map;
}
- static Map<TestData.Key, Collection<RecordIntPairMatch>> matchRecordIntPairValues(
+ static Map<Integer, Collection<RecordIntPairMatch>> matchRecordIntPairValues(
--- End diff --
matchTupleIntPairValues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280094
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java ---
@@ -692,24 +685,24 @@ public void join(Record rec1, Record rec2, Collector<Record> out) throws Excepti
}
}
- static final class RecordIntPairMatchRemovingMatcher extends AbstractRichFunction implements FlatJoinFunction<IntPair, Record, Record>
+ static final class RecordIntPairMatchRemovingMatcher extends AbstractRichFunction implements FlatJoinFunction<IntPair, Tuple2<Integer, String>, Tuple2<Integer, String>>
{
- private final Map<TestData.Key, Collection<RecordIntPairMatch>> toRemoveFrom;
+ private final Map<Integer, Collection<RecordIntPairMatch>> toRemoveFrom;
- protected RecordIntPairMatchRemovingMatcher(Map<TestData.Key, Collection<RecordIntPairMatch>> map) {
+ protected RecordIntPairMatchRemovingMatcher(Map<Integer, Collection<RecordIntPairMatch>> map) {
--- End diff --
TupleIntPairMatchRemovingMatcher
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280556
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/NonReusingHashMatchIteratorITCase.java ---
@@ -725,7 +716,7 @@ public void join(IntPair rec1, Record rec2, Collector<Record> out) throws Except
}
}
- static final class IntPairRecordPairComparator extends TypePairComparator<IntPair, Record>
+ static final class IntPairRecordPairComparator extends TypePairComparator<IntPair, Tuple2<Integer, String>>
--- End diff --
IntPairTuplePairComparator
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41279695
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java ---
@@ -608,10 +601,10 @@ public void testBuildSecondWithMixedDataTypes() {
*/
static class RecordMatch {
--- End diff --
TupleMatch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41279829
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java ---
@@ -498,15 +491,15 @@ public void testBuildSecondWithMixedDataTypes() {
- static Map<TestData.Key, Collection<RecordMatch>> matchRecordValues(
- Map<TestData.Key, Collection<TestData.Value>> leftMap,
- Map<TestData.Key, Collection<TestData.Value>> rightMap)
+ static Map<Integer, Collection<RecordMatch>> matchRecordValues(
--- End diff --
matchTupleValues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41279751
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java ---
@@ -562,21 +555,21 @@ public void testBuildSecondWithMixedDataTypes() {
}
- static Map<TestData.Key, Collection<TestData.Value>> collectRecordData(MutableObjectIterator<Record> iter)
+ static Map<Integer, Collection<String>> collectRecordData(MutableObjectIterator<Tuple2<Integer, String>> iter)
--- End diff --
collectTupleData
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280716
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/NonReusingHashMatchIteratorITCase.java ---
@@ -639,11 +630,11 @@ public String toString() {
static class RecordIntPairMatch
--- End diff --
TupleIntPairMatch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1160#issuecomment-148323391
Thanks for the update @zentol!
I will merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280692
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/NonReusingHashMatchIteratorITCase.java ---
@@ -608,10 +599,10 @@ public void testBuildSecondWithMixedDataTypes() {
*/
static class RecordMatch {
--- End diff --
TupleMatch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280618
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/NonReusingHashMatchIteratorITCase.java ---
@@ -692,24 +683,24 @@ public void join(Record rec1, Record rec2, Collector<Record> out) throws Excepti
}
}
- static final class RecordIntPairMatchRemovingMatcher extends AbstractRichFunction implements FlatJoinFunction<IntPair, Record, Record>
+ static final class RecordIntPairMatchRemovingMatcher implements FlatJoinFunction<IntPair, Tuple2<Integer, String>, Tuple2<Integer, String>>
--- End diff --
TupleIntPairMatchRemovingMatcher
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41279256
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java ---
@@ -725,7 +718,7 @@ public void join(IntPair rec1, Record rec2, Collector<Record> out) throws Except
}
}
- static final class IntPairRecordPairComparator extends TypePairComparator<IntPair, Record>
+ static final class IntPairRecordPairComparator extends TypePairComparator<IntPair, Tuple2<Integer, String>>
--- End diff --
should be IntPairTuplePairComparator
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1160#issuecomment-142061495
That is very nice, thanks for the initiative, @zentol
Hope to be able to have a look over it, soon. Looks in principle correct, but cannot hurt to have another pair of eyes check for subtle mistakes...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41279675
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java ---
@@ -639,9 +632,9 @@ public String toString() {
static class RecordIntPairMatch
--- End diff --
TupleIntPairMatch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41279323
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java ---
@@ -692,24 +685,24 @@ public void join(Record rec1, Record rec2, Collector<Record> out) throws Excepti
}
}
- static final class RecordIntPairMatchRemovingMatcher extends AbstractRichFunction implements FlatJoinFunction<IntPair, Record, Record>
+ static final class RecordIntPairMatchRemovingMatcher extends AbstractRichFunction implements FlatJoinFunction<IntPair, Tuple2<Integer, String>, Tuple2<Integer, String>>
--- End diff --
should be TupleIntPairMatchRemovingMatcher
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280508
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/NonReusingHashMatchIteratorITCase.java ---
@@ -735,33 +726,31 @@ public void setReference(IntPair reference) {
}
@Override
- public boolean equalToReference(Record candidate) {
+ public boolean equalToReference(Tuple2<Integer, String> candidate) {
try {
- final IntValue i = candidate.getField(0, IntValue.class);
- return i.getValue() == this.reference;
+ return candidate.f0 == this.reference;
} catch (NullPointerException npex) {
throw new NullKeyFieldException();
}
}
@Override
- public int compareToReference(Record candidate) {
+ public int compareToReference(Tuple2<Integer, String> candidate) {
try {
- final IntValue i = candidate.getField(0, IntValue.class);
- return i.getValue() - this.reference;
+ return candidate.f0 - this.reference;
} catch (NullPointerException npex) {
throw new NullKeyFieldException();
}
}
}
- static final class RecordIntPairPairComparator extends TypePairComparator<Record, IntPair>
+ static final class RecordIntPairPairComparator extends TypePairComparator<Tuple2<Integer, String>, IntPair>
--- End diff --
TupleIntPairPairComparator
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---