You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Lixiongyou (via GitHub)" <gi...@apache.org> on 2024/10/12 13:15:33 UTC

[PR] Add SubnetAddressIterable & SubnetAddressIterator [commons-net]

Lixiongyou opened a new pull request, #298:
URL: https://github.com/apache/commons-net/pull/298

   org.apache.commons.net.util.SubnetUtils.SubnetInfo#getAllAddresses method may take too much memory when dealing with subnet like "1.0.0.0/8", so add SubnetAddressIterable & SubnetAddressIterator to implement similar function.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add SubnetAddressIterable & SubnetAddressIterator [commons-net]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #298:
URL: https://github.com/apache/commons-net/pull/298


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add SubnetAddressIterable & SubnetAddressIterator [commons-net]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #298:
URL: https://github.com/apache/commons-net/pull/298#issuecomment-2408995904

   @Lixiongyou 
   
   Thank you for your PR. I added some Javadoc and used final. Please make sure future PR contain full Javadocs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org