[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #1977: Enable serialized_reader read specific Page by passing row ranges.

[GitBox <gi...@apache.org>]

Ted-Jiang commented on code in PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#discussion_r911719190


##########
parquet/src/column/reader.rs:
##########
@@ -160,9 +163,14 @@ where
             num_buffered_values: 0,
             num_decoded_values: 0,
             values_decoder,
+            selected_row_ranges: None,
         }
     }
 
+    pub(crate) fn set_row_ranges(&mut self, row_ranges: RowRanges) {
+        self.selected_row_ranges = Some(row_ranges);

Review Comment:
   Todo need this row_ranges for row align



##########
parquet/src/file/serialized_reader.rs:
##########
@@ -353,6 +392,31 @@ impl<'a, R: 'static + ChunkReader> RowGroupReader for SerializedRowGroupReader<'
         Ok(Box::new(page_reader))
     }
 
+    fn get_column_page_reader_with_offset_index(

Review Comment:
   Cause of lack test data in sub project in `parquet-testing`, will add end to end test after add test file in it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org