You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by Michael Bien <mb...@gmail.com> on 2020/08/06 12:48:30 UTC
StylesheetEdit.jsp never receives custom stylesheets
Hello,
is the master branch currently up2date?
if yes then i might have just fixed a bug:
StylesheetEdit only sets the stylesheet if it is shared, never when its
a custom theme. This causes the Design/Stylesheet page to think that the
theme doesn't have a stylesheet.
the file in roller master:
https://github.com/apache/roller/blob/master/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/StylesheetEdit.java#L72
the fix in my wip branch:
https://github.com/mbien/roller/commit/1b5ecf896368f8e49d8f0a928da3ed827991cc10
best regards,
michael
Re: StylesheetEdit.jsp never receives custom stylesheets
Posted by Michael Bien <mb...@gmail.com>.
awesome!
best regards,
michael
On 23.08.20 15:49, Dave wrote:
> Yes, master is now up-dated with the latest from the 6.0.x branch.
>
> And, your stylesheet fix looks good.
>
> Thanks!
> Dave
>
>
> On Sun, Aug 23, 2020 at 8:00 AM Michael Bien <mb...@gmail.com> wrote:
>
>> ping
>>
>>
>> On 06.08.20 14:48, Michael Bien wrote:
>>> Hello,
>>>
>>> is the master branch currently up2date?
>>>
>>>
>>> if yes then i might have just fixed a bug:
>>>
>>> StylesheetEdit only sets the stylesheet if it is shared, never when
>>> its a custom theme. This causes the Design/Stylesheet page to think
>>> that the theme doesn't have a stylesheet.
>>>
>>> the file in roller master:
>>>
>>>
>> https://github.com/apache/roller/blob/master/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/StylesheetEdit.java#L72
>>>
>>> the fix in my wip branch:
>>>
>>>
>> https://github.com/mbien/roller/commit/1b5ecf896368f8e49d8f0a928da3ed827991cc10
>>>
>>>
>>> best regards,
>>>
>>> michael
>>>
>>
Re: StylesheetEdit.jsp never receives custom stylesheets
Posted by Dave <sn...@gmail.com>.
Yes, master is now up-dated with the latest from the 6.0.x branch.
And, your stylesheet fix looks good.
Thanks!
Dave
On Sun, Aug 23, 2020 at 8:00 AM Michael Bien <mb...@gmail.com> wrote:
> ping
>
>
> On 06.08.20 14:48, Michael Bien wrote:
> > Hello,
> >
> > is the master branch currently up2date?
> >
> >
> > if yes then i might have just fixed a bug:
> >
> > StylesheetEdit only sets the stylesheet if it is shared, never when
> > its a custom theme. This causes the Design/Stylesheet page to think
> > that the theme doesn't have a stylesheet.
> >
> > the file in roller master:
> >
> >
> https://github.com/apache/roller/blob/master/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/StylesheetEdit.java#L72
> >
> >
> > the fix in my wip branch:
> >
> >
> https://github.com/mbien/roller/commit/1b5ecf896368f8e49d8f0a928da3ed827991cc10
> >
> >
> >
> > best regards,
> >
> > michael
> >
>
>
Re: StylesheetEdit.jsp never receives custom stylesheets
Posted by Michael Bien <mb...@gmail.com>.
ping
On 06.08.20 14:48, Michael Bien wrote:
> Hello,
>
> is the master branch currently up2date?
>
>
> if yes then i might have just fixed a bug:
>
> StylesheetEdit only sets the stylesheet if it is shared, never when
> its a custom theme. This causes the Design/Stylesheet page to think
> that the theme doesn't have a stylesheet.
>
> the file in roller master:
>
> https://github.com/apache/roller/blob/master/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/StylesheetEdit.java#L72
>
>
> the fix in my wip branch:
>
> https://github.com/mbien/roller/commit/1b5ecf896368f8e49d8f0a928da3ed827991cc10
>
>
>
> best regards,
>
> michael
>