You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "razeghi71 (via GitHub)" <gi...@apache.org> on 2023/12/02 03:49:38 UTC
[PR] add a summary table to benchmark compare output [arrow-datafusion]
razeghi71 opened a new pull request, #8399:
URL: https://github.com/apache/arrow-datafusion/pull/8399
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #8390.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Explained in issue.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Adding a Benchmark summary at the end of compare table like this:
```
Comparing main and test
--------------------
Benchmark parquet.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ main ┃ test ┃ Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QSelective-… │ 1297.07ms │ 1246.13ms │ no change │
│ filter: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QSelective-… │ 2213.53ms │ 2207.27ms │ no change │
│ filter: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QSelective-… │ 2180.89ms │ 2114.42ms │ no change │
│ filter: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QNon-select… │ 1669.30ms │ 1631.17ms │ no change │
│ filter: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QNon-select… │ 3093.85ms │ 3024.91ms │ no change │
│ filter: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QNon-select… │ 3040.35ms │ 2983.02ms │ no change │
│ filter: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QBasic │ 1187.55ms │ 1123.46ms │ +1.06x faster │
│ conjunction: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QBasic │ 932.60ms │ 897.74ms │ no change │
│ conjunction: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QBasic │ 929.53ms │ 865.66ms │ +1.07x faster │
│ conjunction: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QNested │ 1242.48ms │ 1188.84ms │ no change │
│ filters: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QNested │ 1339.34ms │ 1309.98ms │ no change │
│ filters: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QNested │ 1301.71ms │ 1265.51ms │ no change │
│ filters: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QMany │ 1518.14ms │ 1511.99ms │ no change │
│ filters: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QMany │ 2496.19ms │ 2502.37ms │ no change │
│ filters: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QMany │ 2482.25ms │ 2524.43ms │ no change │
│ filters: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QFilter │ 1349.09ms │ 1127.22ms │ +1.20x faster │
│ everything: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QFilter │ 20.69ms │ 21.37ms │ no change │
│ everything: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QFilter │ 21.91ms │ 21.17ms │ no change │
│ everything: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QFilter │ 1190.26ms │ 1164.32ms │ no change │
│ nothing: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QFilter │ 1137.58ms │ 1099.04ms │ no change │
│ nothing: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
│ QFilter │ 1185.82ms │ 1199.38ms │ no change │
│ nothing: │ │ │ │
│ pushdown_fi… │ │ │ │
│ reorder_fil… │ │ │ │
│ page_index=… │ │ │ │
└──────────────┴───────────┴───────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (main) │ 31830.11ms │
│ Total Time (test) │ 31029.41ms │
│ Average Time (main) │ 1515.72ms │
│ Average Time (test) │ 1477.59ms │
│ Queries Faster │ 3 │
│ Queries Slower │ 0 │
│ Queries with No Change │ 18 │
└────────────────────────┴────────────┘
```
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
I didn't add a test as this was UI change, and it didn't have a test before.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
The output of the compare command is changed, but I didn't see if it was shown anywhere in the docs.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add a summary table to benchmark compare output [arrow-datafusion]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #8399:
URL: https://github.com/apache/arrow-datafusion/pull/8399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org