You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ofbiz.apache.org by James Yong <ja...@apache.org> on 2020/11/19 14:13:29 UTC

Remove datejs

Hi all,

Javascript library at themes/common-themes/webapp/common/js/jquery/plugins/datejs doesn't seem to be in use. Suggest to remove it, along with some language-specific code in JsLanguageFilesMapping.java etc.

Regards,
James

Re: Remove datejs

Posted by James Yong <ja...@apache.org>.

Hi all,

Will load language-specific js for date.js only when required.
Created OFBIZ-12064 for it.

Regards,
James

On 2020/11/21 06:47:48, James Yong <ja...@apache.org> wrote: 
> Hi Michael,
> 
> You are right. Found one dependency with datetimepicker.
> Will check further..
> 
> Thanks,
> James
> 
> On 2020/11/20 14:22:53, Michael Brohl <mi...@ecomify.de> wrote: 
> > Are you sure that this is not needed anymore. I have in mind that it is 
> > somehow related to the datepicker.
> > 
> > Regards,
> > 
> > Michael Brohl
> > 
> > ecomify GmbH - www.ecomify.de
> > 
> > 
> > Am 19.11.20 um 18:07 schrieb Jacques Le Roux:
> > > Hi James,
> > >
> > > Though I did not find when it was removed, sounds good to me
> > >
> > > Thanks
> > >
> > > Jacques
> > >
> > > Le 19/11/2020 à 15:13, James Yong a écrit :
> > >> Hi all,
> > >>
> > >> Javascript library at 
> > >> themes/common-themes/webapp/common/js/jquery/plugins/datejs doesn't 
> > >> seem to be in use. Suggest to remove it, along with some 
> > >> language-specific code in JsLanguageFilesMapping.java etc.
> > >>
> > >> Regards,
> > >> James
> > >
> > 
> > 
>

Re: Remove datejs

Posted by James Yong <ja...@apache.org>.

Hi Michael,

You are right. Found one dependency with datetimepicker.
Will check further..

Thanks,
James

On 2020/11/20 14:22:53, Michael Brohl <mi...@ecomify.de> wrote: 
> Are you sure that this is not needed anymore. I have in mind that it is 
> somehow related to the datepicker.
> 
> Regards,
> 
> Michael Brohl
> 
> ecomify GmbH - www.ecomify.de
> 
> 
> Am 19.11.20 um 18:07 schrieb Jacques Le Roux:
> > Hi James,
> >
> > Though I did not find when it was removed, sounds good to me
> >
> > Thanks
> >
> > Jacques
> >
> > Le 19/11/2020 à 15:13, James Yong a écrit :
> >> Hi all,
> >>
> >> Javascript library at 
> >> themes/common-themes/webapp/common/js/jquery/plugins/datejs doesn't 
> >> seem to be in use. Suggest to remove it, along with some 
> >> language-specific code in JsLanguageFilesMapping.java etc.
> >>
> >> Regards,
> >> James
> >
> 
>

Re: Remove datejs

Posted by Michael Brohl <mi...@ecomify.de>.

Are you sure that this is not needed anymore. I have in mind that it is 
somehow related to the datepicker.

Regards,

Michael Brohl

ecomify GmbH - www.ecomify.de


Am 19.11.20 um 18:07 schrieb Jacques Le Roux:
> Hi James,
>
> Though I did not find when it was removed, sounds good to me
>
> Thanks
>
> Jacques
>
> Le 19/11/2020 à 15:13, James Yong a écrit :
>> Hi all,
>>
>> Javascript library at 
>> themes/common-themes/webapp/common/js/jquery/plugins/datejs doesn't 
>> seem to be in use. Suggest to remove it, along with some 
>> language-specific code in JsLanguageFilesMapping.java etc.
>>
>> Regards,
>> James
>

Re: Remove datejs

Posted by Jacques Le Roux <ja...@les7arts.com>.

Hi James,

Though I did not find when it was removed, sounds good to me

Thanks

Jacques

Le 19/11/2020 à 15:13, James Yong a écrit :
> Hi all,
>
> Javascript library at themes/common-themes/webapp/common/js/jquery/plugins/datejs doesn't seem to be in use. Suggest to remove it, along with some language-specific code in JsLanguageFilesMapping.java etc.
>
> Regards,
> James