You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/02 15:15:15 UTC

[GitHub] [commons-compress] bodewig opened a new pull request #210: Pack200 harmony as fallback

bodewig opened a new pull request #210:
URL: https://github.com/apache/commons-compress/pull/210


   Hi @garydgregory 
   
   I'm only half-serious about this PR.
   
   Personally I'd like to use java.util.jar.Pack200 if it is available and fallback to Harmony's code if it isn't. I've managed to do so with a bunch of facades and a little reflection, but it seems to work - all tests pass for all JDKs tested.
   
   I had to pick up a few changes from master to make things work in github actions, but we need to rebase anyway.
   
   Right now only javadoc stuff fails AFAICT, and even that is probably going to pass once the change is rebased.
   
   If you like my changes, then let's move forward with that. If you prefer your pure Harmony solution I can live with that very well - feel free to merge it to master however you see fit.
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] bodewig closed pull request #210: Pack200 harmony as fallback

Posted by GitBox <gi...@apache.org>.

bodewig closed pull request #210:
URL: https://github.com/apache/commons-compress/pull/210


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] bodewig commented on pull request #210: Pack200 harmony as fallback

Posted by GitBox <gi...@apache.org>.

bodewig commented on pull request #210:
URL: https://github.com/apache/commons-compress/pull/210#issuecomment-873357342


   I have rebased the branch against master and close the PR. This can be revisited later if anybody is interested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] coveralls commented on pull request #210: Pack200 harmony as fallback

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #210:
URL: https://github.com/apache/commons-compress/pull/210#issuecomment-873357737


   
   [![Coverage Status](https://coveralls.io/builds/41093854/badge)](https://coveralls.io/builds/41093854)
   
   Coverage decreased (-9.3%) to 51.69% when pulling **d35803651d0e992d19db9da71a0a2e5082c865d2 on pack200-harmony-as-fallback** into **8522651d53566458c345b8ebe423eb6dfd580a47 on pack200**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org