You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/01 03:13:13 UTC
[GitHub] [incubator-doris] frwrdt opened a new pull request #3237: Broker
load username
frwrdt opened a new pull request #3237: Broker load username
URL: https://github.com/apache/incubator-doris/pull/3237
fix bug in issue #3234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] frwrdt commented on a change in pull request
#3237: Broker load username
Posted by GitBox <gi...@apache.org>.
frwrdt commented on a change in pull request #3237: Broker load username
URL: https://github.com/apache/incubator-doris/pull/3237#discussion_r401371953
##########
File path: fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java
##########
@@ -338,7 +333,20 @@ public BrokerFileSystem getDistributedFileSystem(String path, Map<String, String
}
conf.set(FS_HDFS_IMPL_DISABLE_CACHE, "true");
- FileSystem dfsFileSystem = FileSystem.get(pathUri.getUri(), conf);
+ FileSystem dfsFileSystem = null;
Review comment:
The version 2.7.3 of package _hadoop-common_ including this method is the same as package _hadoop-hdfs_.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request
#3237: Broker load username
Posted by GitBox <gi...@apache.org>.
HangyuanLiu commented on a change in pull request #3237: Broker load username
URL: https://github.com/apache/incubator-doris/pull/3237#discussion_r401335808
##########
File path: fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java
##########
@@ -287,9 +285,6 @@ public BrokerFileSystem getDistributedFileSystem(String path, Map<String, String
e.getMessage());
}
}
- } else {
- throw new BrokerException(TBrokerOperationStatusCode.INVALID_ARGUMENT,
- "invalid authentication.");
Review comment:
We need to determine whether the authentication method exists
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request
#3237: Broker load username
Posted by GitBox <gi...@apache.org>.
HangyuanLiu commented on a change in pull request #3237: Broker load username
URL: https://github.com/apache/incubator-doris/pull/3237#discussion_r401336230
##########
File path: fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java
##########
@@ -338,7 +333,20 @@ public BrokerFileSystem getDistributedFileSystem(String path, Map<String, String
}
conf.set(FS_HDFS_IMPL_DISABLE_CACHE, "true");
- FileSystem dfsFileSystem = FileSystem.get(pathUri.getUri(), conf);
+ FileSystem dfsFileSystem = null;
Review comment:
Is this method compatible with versions of hdfs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HangyuanLiu commented on issue #3237: Broker load
username
Posted by GitBox <gi...@apache.org>.
HangyuanLiu commented on issue #3237: Broker load username
URL: https://github.com/apache/incubator-doris/pull/3237#issuecomment-607007208
Please change to a understandable title
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HangyuanLiu edited a comment on issue #3237:
Broker load username
Posted by GitBox <gi...@apache.org>.
HangyuanLiu edited a comment on issue #3237: Broker load username
URL: https://github.com/apache/incubator-doris/pull/3237#issuecomment-607007208
Please change to an understandable title
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] frwrdt commented on a change in pull request
#3237: Broker load username
Posted by GitBox <gi...@apache.org>.
frwrdt commented on a change in pull request #3237: Broker load username
URL: https://github.com/apache/incubator-doris/pull/3237#discussion_r401338318
##########
File path: fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java
##########
@@ -287,9 +285,6 @@ public BrokerFileSystem getDistributedFileSystem(String path, Map<String, String
e.getMessage());
}
}
- } else {
- throw new BrokerException(TBrokerOperationStatusCode.INVALID_ARGUMENT,
- "invalid authentication.");
Review comment:
The authentication has been checked before, so this is redundant here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #3237: fix the bug that
'username' in broker load is invalid
Posted by GitBox <gi...@apache.org>.
imay merged pull request #3237: fix the bug that 'username' in broker load is invalid
URL: https://github.com/apache/incubator-doris/pull/3237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org