You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/08/16 18:27:51 UTC

[GitHub] [maven-enforcer] josephlbarnett opened a new pull request #102: [MENFORCER-394] Ignore provided/optional/test dependencies in Depende…

josephlbarnett opened a new pull request #102:
URL: https://github.com/apache/maven-enforcer/pull/102


   …ncyConvergence
   
   This matches the 3.0.0-M3 behavior of the DependencyConvergence rule
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-enforcer] vebits commented on pull request #102: [MENFORCER-394] Only look at shipped dependencies in DependencyConvergence

Posted by GitBox <gi...@apache.org>.
vebits commented on pull request #102:
URL: https://github.com/apache/maven-enforcer/pull/102#issuecomment-972736245


   Any ETA on a 3.0.1 release with this change? @slachiewicz 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-enforcer] slachiewicz closed pull request #102: [MENFORCER-394] Only look at shipped dependencies in DependencyConvergence

Posted by GitBox <gi...@apache.org>.
slachiewicz closed pull request #102:
URL: https://github.com/apache/maven-enforcer/pull/102


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-enforcer] rfscholte commented on pull request #102: [MENFORCER-394] Only look at shipped dependencies in DependencyConvergence

Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #102:
URL: https://github.com/apache/maven-enforcer/pull/102#issuecomment-909494440


   I need to push some plugins in preparation of Java 17 first. Also want to understand the change to `dependencies_not_converging_test_scope/invoker.properties `.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-enforcer] slachiewicz commented on pull request #102: [MENFORCER-394] Only look at shipped dependencies in DependencyConvergence

Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #102:
URL: https://github.com/apache/maven-enforcer/pull/102#issuecomment-969377478


   merged, thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-enforcer] josephlbarnett commented on pull request #102: [MENFORCER-394] Only look at shipped dependencies in DependencyConvergence

Posted by GitBox <gi...@apache.org>.
josephlbarnett commented on pull request #102:
URL: https://github.com/apache/maven-enforcer/pull/102#issuecomment-899838253


   Looks like there was an integration test for this case designed to fail, so I've set it to pass instead.  not sure how that test was successful in 3.0.0-M3 though?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-enforcer] rfscholte commented on pull request #102: [MENFORCER-394] Only look at shipped dependencies in DependencyConvergence

Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #102:
URL: https://github.com/apache/maven-enforcer/pull/102#issuecomment-909494440


   I need to push some plugins in preparation of Java 17 first. Also want to understand the change to `dependencies_not_converging_test_scope/invoker.properties `.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-enforcer] kgunnerud commented on pull request #102: [MENFORCER-394] Only look at shipped dependencies in DependencyConvergence

Posted by GitBox <gi...@apache.org>.
kgunnerud commented on pull request #102:
URL: https://github.com/apache/maven-enforcer/pull/102#issuecomment-902478872


   Great that this will be fixed. After upgrading to Spring Boot 2.5.4 which was released yesterday, they bumped maven-enforcer-plugin version and a lot of convergence was reported on dependencies that had provided scope. In a self-contained fat-jar few provided resources actually will be provided.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-enforcer] josephlbarnett commented on pull request #102: [MENFORCER-394] Only look at shipped dependencies in DependencyConvergence

Posted by GitBox <gi...@apache.org>.
josephlbarnett commented on pull request #102:
URL: https://github.com/apache/maven-enforcer/pull/102#issuecomment-909451879


   @rfscholte any feedback on next steps here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-enforcer] rfscholte commented on pull request #102: [MENFORCER-394] Only look at shipped dependencies in DependencyConvergence

Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #102:
URL: https://github.com/apache/maven-enforcer/pull/102#issuecomment-899741502


   This deserves an integration test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-enforcer] josephlbarnett commented on pull request #102: [MENFORCER-394] Only look at shipped dependencies in DependencyConvergence

Posted by GitBox <gi...@apache.org>.
josephlbarnett commented on pull request #102:
URL: https://github.com/apache/maven-enforcer/pull/102#issuecomment-909451879


   @rfscholte any feedback on next steps here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org