You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/01 22:39:29 UTC

[GitHub] [incubator-tvm] tqchen opened a new pull request #5711: Remove deprecated opengl files

tqchen opened a new pull request #5711:
URL: https://github.com/apache/incubator-tvm/pull/5711


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] icemelon9 commented on pull request #5711: Remove deprecated opengl files

Posted by GitBox <gi...@apache.org>.
icemelon9 commented on pull request #5711:
URL: https://github.com/apache/incubator-tvm/pull/5711#issuecomment-637179418


   Do we still need the `type_hint` in the device API that is specific for opengl?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5711: Remove deprecated opengl files

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5711:
URL: https://github.com/apache/incubator-tvm/pull/5711#issuecomment-637204039


   @icemelon9 I think it makes sense to keep it since future graphics API like vulkan could benefit from it, if we decide to extend include texture memory support.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] zhiics commented on pull request #5711: Remove deprecated opengl files

Posted by GitBox <gi...@apache.org>.
zhiics commented on pull request #5711:
URL: https://github.com/apache/incubator-tvm/pull/5711#issuecomment-637174561


   BTW, do we still need to keep the files under src/runtime/opengl ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5711: Remove deprecated opengl files

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5711:
URL: https://github.com/apache/incubator-tvm/pull/5711#issuecomment-637162637


   cc @icemelon9 @zhiics @yzhliu 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5711: Remove deprecated opengl files

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5711:
URL: https://github.com/apache/incubator-tvm/pull/5711#issuecomment-637205361


   @zhiics Good point, i opened https://github.com/apache/incubator-tvm/pull/5712 for that


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #5711: Remove deprecated opengl files

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5711:
URL: https://github.com/apache/incubator-tvm/pull/5711


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org