You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/17 09:08:24 UTC

[GitHub] [apisix-website] oil-oil opened a new pull request #884: feat: support language detection

oil-oil opened a new pull request #884:
URL: https://github.com/apache/apisix-website/pull/884


   Fixes: #743
   
   Changes:
   
   Added a method to check the browser language and jump to the Chinese page if the language is Chinese.
   
   Screenshots of the change:
   
   no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on pull request #884: feat: support language detection

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #884:
URL: https://github.com/apache/apisix-website/pull/884#issuecomment-1055034037


   > 
   
   Yes, we could have more discussions on the issue before coding 🤗 I will add discuss label to that issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] oil-oil commented on pull request #884: feat: support language detection

Posted by GitBox <gi...@apache.org>.
oil-oil commented on pull request #884:
URL: https://github.com/apache/apisix-website/pull/884#issuecomment-1054884367


   > One problem I found now is that when a user using Chinese needs to view an English document, it will be brought back to Chinese mode again and we need to allow users to manually switch to English documents.
   
   I thought about it, but there seems to be no good solution to this problem at present. And if the Chinese content is missing in the future, it is not advisable to directly jump to the Chinese page.🧐


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #884: feat: support language detection

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #884:
URL: https://github.com/apache/apisix-website/pull/884#issuecomment-1042723457


   ❌ Deploy Preview for *apache-apisix* failed.
   
   
   🔨 Explore the source changes: 7e6543956a498cdec719601a7a9fb2dedf51a22d
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620e1081a4180000086b5263](https://app.netlify.com/sites/apache-apisix/deploys/620e1081a4180000086b5263)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan closed pull request #884: feat: support language detection

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed pull request #884:
URL: https://github.com/apache/apisix-website/pull/884


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] commented on pull request #884: feat: support language detection

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #884:
URL: https://github.com/apache/apisix-website/pull/884#issuecomment-1042723457


   👷 Deploy Preview for *apache-apisix* processing.
   
   
   🔨 Explore the source changes: 7e6543956a498cdec719601a7a9fb2dedf51a22d
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620e1081a4180000086b5263](https://app.netlify.com/sites/apache-apisix/deploys/620e1081a4180000086b5263)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] bzp2010 commented on pull request #884: feat: support language detection

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #884:
URL: https://github.com/apache/apisix-website/pull/884#issuecomment-1053479797


   One problem I found now is that when a user using Chinese needs to view an English document, it will be brought back to Chinese mode again and we need to allow users to manually switch to English documents.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] SkyeYoung commented on pull request #884: feat: support language detection

Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on pull request #884:
URL: https://github.com/apache/apisix-website/pull/884#issuecomment-1082519799


   This maybe should be closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on pull request #884: feat: support language detection

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #884:
URL: https://github.com/apache/apisix-website/pull/884#issuecomment-1082623133


   Indeed. We have implemented :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #884: feat: support language detection

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #884:
URL: https://github.com/apache/apisix-website/pull/884#issuecomment-1042723457


   👷 Deploy Preview for *apache-apisix* processing.
   
   
   🔨 Explore the source changes: 44117008564483a8c9c95cab6a583fc60024bc50
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620e1e6267510200089f28c0](https://app.netlify.com/sites/apache-apisix/deploys/620e1e6267510200089f28c0)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] oil-oil edited a comment on pull request #884: feat: support language detection

Posted by GitBox <gi...@apache.org>.
oil-oil edited a comment on pull request #884:
URL: https://github.com/apache/apisix-website/pull/884#issuecomment-1053745456


   > One problem I found now is that when a user using Chinese needs to view an English document, it will be brought back to Chinese mode again and we need to allow users to manually switch to English documents.
   
   OK, i'll check it out.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] oil-oil commented on pull request #884: feat: support language detection

Posted by GitBox <gi...@apache.org>.
oil-oil commented on pull request #884:
URL: https://github.com/apache/apisix-website/pull/884#issuecomment-1053745456


   > One problem I found now is that when a user using Chinese needs to view an English document, it will be brought back to Chinese mode again and we need to allow users to manually switch to English documents.
   OK, i'll check it out.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #884: feat: support language detection

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #884:
URL: https://github.com/apache/apisix-website/pull/884#issuecomment-1042723457


   ✔️ Deploy Preview for *apache-apisix* ready!
   
   
   🔨 Explore the source changes: 44117008564483a8c9c95cab6a583fc60024bc50
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/620e1e6267510200089f28c0](https://app.netlify.com/sites/apache-apisix/deploys/620e1e6267510200089f28c0)
   
   😎 Browse the preview: [https://deploy-preview-884--apache-apisix.netlify.app](https://deploy-preview-884--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org