You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Dennis Byrne (JIRA)" <ax...@ws.apache.org> on 2005/07/02 10:28:10 UTC

[jira] Commented: (AXIS-2088) backslash in wsdl:service[@name] generates bad java

    [ http://issues.apache.org/jira/browse/AXIS-2088?page=comments#action_12314944 ] 

Dennis Byrne commented on AXIS-2088:
------------------------------------

Can one of the commiters please take a look at this.  When running this, I am no longer able to reproduce bug # AXIS-2088 .  

Problem: 
When wsdl:service[@name] = "ServiceNa\me", you get an interface named ServiceNaMe and an implementation class called  ServiceNaMeLocator.  Also, the "ServiceNa\me" ends up as a string in ServiceNaMeLocator.getServiceName() .

Proposed Solution:
No more funny Java class names and escape all backslash chars in the string literal.

Proposed Fix:
1.) add a property to org.apache.axis.wsdl.symbolTable.ServiceEntry called originalServiceName.
2.) change org.apache.axis.wsdl.toJava.JavaServiceImplWriter.writeGetServiceName() to use ServiceEntry.originalServiceName in order to escape backslash chars.
3.) change org.apache.axis.wsdl.symbolTable.SymbolTable.populateServices() to record ServiceEntry.originalServiceName, but otherwise ignore backslash chars in wsdl:service[@name] .
4.) commit a BackslashUtil class to repository, or at least get it's static methods in there somewhere.

I will attach two files, one is the BackslashUtil and the other is a copy of all three refactored methods.


> backslash in wsdl:service[@name] generates bad java
> ---------------------------------------------------
>
>          Key: AXIS-2088
>          URL: http://issues.apache.org/jira/browse/AXIS-2088
>      Project: Apache Axis
>         Type: Bug
>   Components: WSDL processing
>     Versions: 1.2.1
>  Environment: observed on WinXP, in both Axis 1.2.1 and the latest CVS checkout, using java version "1.4.2_06"
>     Reporter: Dennis Byrne
>     Priority: Minor
>  Attachments: BackslashUtil.java, refactoredMethods.txt
>
> see bottom of http://groups.yahoo.com/group/jsr110-eg-disc/message/664 for details.
> I have categorized this as minor because I just don't think this is a likely situation.  I'll work on a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira