You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/06/26 23:27:56 UTC
[kudu-CR] [loadgen] don't report per-row timing if errors happened
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13742
Change subject: [loadgen] don't report per-row timing if errors happened
......................................................................
[loadgen] don't report per-row timing if errors happened
The per-row timings are misleading in case if a write error happened
while inserting generated rows into the test table, so don't
report those.
Change-Id: I501aad05fa6bd8a5b540c53c8e3f27baff4bde84
---
M src/kudu/tools/tool_action_perf.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/13742/1
--
To view, visit http://gerrit.cloudera.org:8080/13742
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I501aad05fa6bd8a5b540c53c8e3f27baff4bde84
Gerrit-Change-Number: 13742
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [loadgen] don't report per-row timing if errors happened
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13742 )
Change subject: [loadgen] don't report per-row timing if errors happened
......................................................................
Patch Set 1: Code-Review+2
I was confused at first about the motivation for this because I thought total_row_count was the total successfully inserted. I clarified this with Alexey, it's actually the total generated and attempted to be inserted. Maybe with some variable renaming this could be clearer, though not a blocker for this patch; otherwise this change LGTM.
--
To view, visit http://gerrit.cloudera.org:8080/13742
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I501aad05fa6bd8a5b540c53c8e3f27baff4bde84
Gerrit-Change-Number: 13742
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Jun 2019 23:41:37 +0000
Gerrit-HasComments: No
[kudu-CR] [loadgen] don't report per-row timing if errors happened
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13742 )
Change subject: [loadgen] don't report per-row timing if errors happened
......................................................................
Patch Set 2: Verified+1
unrelated flake in TestRpc.TestServerShutsDown
--
To view, visit http://gerrit.cloudera.org:8080/13742
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I501aad05fa6bd8a5b540c53c8e3f27baff4bde84
Gerrit-Change-Number: 13742
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 02:51:58 +0000
Gerrit-HasComments: No
[kudu-CR] [loadgen] don't report per-row timing if errors happened
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13742 )
Change subject: [loadgen] don't report per-row timing if errors happened
......................................................................
[loadgen] don't report per-row timing if errors happened
The per-row timings are misleading in case if a write error happened
while inserting generated rows into the test table, so don't
report those.
The motivation for this change was seeing per-row timings in case
when not a single generated row was inserted.
Change-Id: I501aad05fa6bd8a5b540c53c8e3f27baff4bde84
Reviewed-on: http://gerrit.cloudera.org:8080/13742
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tools/tool_action_perf.cc
1 file changed, 19 insertions(+), 14 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13742
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I501aad05fa6bd8a5b540c53c8e3f27baff4bde84
Gerrit-Change-Number: 13742
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] [loadgen] don't report per-row timing if errors happened
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13742 )
Change subject: [loadgen] don't report per-row timing if errors happened
......................................................................
Patch Set 2:
> Thanks for updating that, Alexey!
Thank you for the review.
--
To view, visit http://gerrit.cloudera.org:8080/13742
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I501aad05fa6bd8a5b540c53c8e3f27baff4bde84
Gerrit-Change-Number: 13742
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 02:52:18 +0000
Gerrit-HasComments: No
[kudu-CR] [loadgen] don't report per-row timing if errors happened
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13742
to look at the new patch set (#2).
Change subject: [loadgen] don't report per-row timing if errors happened
......................................................................
[loadgen] don't report per-row timing if errors happened
The per-row timings are misleading in case if a write error happened
while inserting generated rows into the test table, so don't
report those.
The motivation for this change was seeing per-row timings in case
when not a single generated row was inserted.
Change-Id: I501aad05fa6bd8a5b540c53c8e3f27baff4bde84
---
M src/kudu/tools/tool_action_perf.cc
1 file changed, 19 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/13742/2
--
To view, visit http://gerrit.cloudera.org:8080/13742
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I501aad05fa6bd8a5b540c53c8e3f27baff4bde84
Gerrit-Change-Number: 13742
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [loadgen] don't report per-row timing if errors happened
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13742 )
Change subject: [loadgen] don't report per-row timing if errors happened
......................................................................
Patch Set 2: Code-Review+2
Thanks for updating that, Alexey!
--
To view, visit http://gerrit.cloudera.org:8080/13742
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I501aad05fa6bd8a5b540c53c8e3f27baff4bde84
Gerrit-Change-Number: 13742
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 27 Jun 2019 01:50:23 +0000
Gerrit-HasComments: No
[kudu-CR] [loadgen] don't report per-row timing if errors happened
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13742 )
Change subject: [loadgen] don't report per-row timing if errors happened
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13742
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I501aad05fa6bd8a5b540c53c8e3f27baff4bde84
Gerrit-Change-Number: 13742
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>