You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "AndreyBozhko (via GitHub)" <gi...@apache.org> on 2024/11/21 22:08:09 UTC
[PR] SOLR-16903: Update CLI tools to use java.nio.file.Path instead of java.io.File [solr]
AndreyBozhko opened a new pull request, #2883:
URL: https://github.com/apache/solr/pull/2883
https://issues.apache.org/jira/browse/SOLR-16903
# Description
I would like to work on SOLR-16903 - this PR only addresses part of it.
Here, I'm migrating the CLI tools from using `java.io.File` to `java.nio.file.Path` APIs.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-16903: Update CLI tools to use java.nio.file.Path instead of java.io.File [solr]
Posted by "AndreyBozhko (via GitHub)" <gi...@apache.org>.
AndreyBozhko commented on PR #2883:
URL: https://github.com/apache/solr/pull/2883#issuecomment-2501620662
@epugh Thanks, I think this piece is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-16903: Update CLI tools to use java.nio.file.Path instead of java.io.File [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #2883:
URL: https://github.com/apache/solr/pull/2883#discussion_r1853138339
##########
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##########
@@ -281,15 +281,15 @@ public void testAppendUrlPath() {
@Test
public void testGuessType() {
File f = new File("foo.doc");
Review Comment:
total nit pick, but would declaring the `File f` as a `Path p` save a `.toPath`???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-16903: Update CLI tools to use java.nio.file.Path instead of java.io.File [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #2883:
URL: https://github.com/apache/solr/pull/2883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-16903: Update CLI tools to use java.nio.file.Path instead of java.io.File [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2883:
URL: https://github.com/apache/solr/pull/2883#issuecomment-2501669337
@AndreyBozhko please do tag me as you keep doing these! I also like to keep an eye on https://ci-builds.apache.org/job/Solr/job/Solr-Test-main/ to make sure things remain good as these changes are made!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-16903: Update CLI tools to use java.nio.file.Path instead of java.io.File [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2883:
URL: https://github.com/apache/solr/pull/2883#issuecomment-2501659957
Since this is purely a refactoring, skipping CHANGES.txt. I am going to apply this to `main` only...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-16903: Update CLI tools to use java.nio.file.Path instead of java.io.File [solr]
Posted by "AndreyBozhko (via GitHub)" <gi...@apache.org>.
AndreyBozhko commented on code in PR #2883:
URL: https://github.com/apache/solr/pull/2883#discussion_r1854492803
##########
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##########
@@ -281,15 +281,15 @@ public void testAppendUrlPath() {
@Test
public void testGuessType() {
File f = new File("foo.doc");
Review Comment:
Yes - but I thought it was best to update the test files separately and at a later point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-16903: Update CLI tools to use java.nio.file.Path instead of java.io.File [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #2883:
URL: https://github.com/apache/solr/pull/2883#discussion_r1854635328
##########
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##########
@@ -281,15 +281,15 @@ public void testAppendUrlPath() {
@Test
public void testGuessType() {
File f = new File("foo.doc");
Review Comment:
awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-16903: Update CLI tools to use java.nio.file.Path instead of java.io.File [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2883:
URL: https://github.com/apache/solr/pull/2883#issuecomment-2500483321
@AndreyBozhko let me know when you feel the PR is ready...!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org