You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2010/07/08 10:17:53 UTC
RE: [PATCH] Add svnrdump
@Bert: could you please trim quoted patches to only the relevant parts?
Scrolling is tedious when I don't have have line folding available...
Bert Huijben wrote on Thu, 8 Jul 2010 at 12:28 -0000:
> > -----Original Message-----
> > From: Ramkumar Ramachandra [mailto:artagnon@gmail.com]
> > Sent: donderdag 8 juli 2010 10:35
> > To: dev@subversion.apache.org
> > Cc: Jonathan Nieder; Sverre Rabbelier; Git Mailing List
> > Subject: [PATCH] Add svnrdump
> >
> > + /* Use a temporary file to measure the text-content-length */
> > + apr_err = apr_temp_dir_get(&tempdir, hb->pool);
svn_io_temp_dir()
> > + if (apr_err != APR_SUCCESS)
> > + SVN_ERR(svn_error_wrap_apr(apr_err, NULL));
> > +
> > + hb->temp_filepath = apr_psprintf(eb->pool, "%s/svn-fe-XXXXXX",
> > tempdir);
>
os.path.join()
Err, I mean, svn_dirent_join().
Re: [PATCH] Add svnrdump
Posted by Ramkumar Ramachandra <ar...@gmail.com>.
Hi Daniel,
Daniel Shahaf writes:
> > > + /* Use a temporary file to measure the text-content-length */
> > > + apr_err = apr_temp_dir_get(&tempdir, hb->pool);
>
> svn_io_temp_dir()
Fixed.
> > > + if (apr_err != APR_SUCCESS)
> > > + SVN_ERR(svn_error_wrap_apr(apr_err, NULL));
> > > +
> > > + hb->temp_filepath = apr_psprintf(eb->pool, "%s/svn-fe-XXXXXX",
> > > tempdir);
> >
>
> os.path.join()
>
> Err, I mean, svn_dirent_join().
Fixed. Thanks :)
-- Ram
Re: [PATCH] Add svnrdump
Posted by Ramkumar Ramachandra <ar...@gmail.com>.
Hi Daniel,
Daniel Shahaf writes:
> > > + /* Use a temporary file to measure the text-content-length */
> > > + apr_err = apr_temp_dir_get(&tempdir, hb->pool);
>
> svn_io_temp_dir()
Fixed.
> > > + if (apr_err != APR_SUCCESS)
> > > + SVN_ERR(svn_error_wrap_apr(apr_err, NULL));
> > > +
> > > + hb->temp_filepath = apr_psprintf(eb->pool, "%s/svn-fe-XXXXXX",
> > > tempdir);
> >
>
> os.path.join()
>
> Err, I mean, svn_dirent_join().
Fixed. Thanks :)
-- Ram
Re: [PATCH] Add svnrdump
Posted by Junio C Hamano <gi...@pobox.com>.
Michael J Gruber <gi...@drmicha.warpmail.net> writes:
> Blair Zajac venit, vidit, dixit 09.07.2010 02:42:
>> On 07/08/2010 01:17 AM, Daniel Shahaf wrote:
>>> @Bert: could you please trim quoted patches to only the relevant parts?
>>> Scrolling is tedious when I don't have have line folding available...
>>
>> +1 on this, in Thunderbird, it took a while to scan through the whole
>> email to see the comments.
>
> <plug>
> That is what the QuoteCollapse extension to Thunderbird was invented for. ;)
> </plug>
>
> In fact, on the git list we tend to trim as little as possible.
What??? Perhaps we are on different git lists?
Re: [PATCH] Add svnrdump
Posted by Sverre Rabbelier <sr...@gmail.com>.
Heya,
On Fri, Jul 9, 2010 at 03:16, Michael J Gruber <gi...@drmicha.warpmail.net> wrote:
> In fact, on the git list we tend to trim as little as possible.
Huh? Quite the opposite I thought...
--
Cheers,
Sverre Rabbelier
Re: [PATCH] Add svnrdump
Posted by Junio C Hamano <gi...@pobox.com>.
Michael J Gruber <gi...@drmicha.warpmail.net> writes:
> Blair Zajac venit, vidit, dixit 09.07.2010 02:42:
>> On 07/08/2010 01:17 AM, Daniel Shahaf wrote:
>>> @Bert: could you please trim quoted patches to only the relevant parts?
>>> Scrolling is tedious when I don't have have line folding available...
>>
>> +1 on this, in Thunderbird, it took a while to scan through the whole
>> email to see the comments.
>
> <plug>
> That is what the QuoteCollapse extension to Thunderbird was invented for. ;)
> </plug>
>
> In fact, on the git list we tend to trim as little as possible.
What??? Perhaps we are on different git lists?
Re: [PATCH] Add svnrdump
Posted by Michael J Gruber <gi...@drmicha.warpmail.net>.
Blair Zajac venit, vidit, dixit 09.07.2010 02:42:
> On 07/08/2010 01:17 AM, Daniel Shahaf wrote:
>> @Bert: could you please trim quoted patches to only the relevant parts?
>> Scrolling is tedious when I don't have have line folding available...
>
> +1 on this, in Thunderbird, it took a while to scan through the whole
> email to see the comments.
<plug>
That is what the QuoteCollapse extension to Thunderbird was invented for. ;)
</plug>
In fact, on the git list we tend to trim as little as possible.
Michael
Re: [PATCH] Add svnrdump
Posted by Michael J Gruber <gi...@drmicha.warpmail.net>.
Blair Zajac venit, vidit, dixit 09.07.2010 02:42:
> On 07/08/2010 01:17 AM, Daniel Shahaf wrote:
>> @Bert: could you please trim quoted patches to only the relevant parts?
>> Scrolling is tedious when I don't have have line folding available...
>
> +1 on this, in Thunderbird, it took a while to scan through the whole
> email to see the comments.
<plug>
That is what the QuoteCollapse extension to Thunderbird was invented for. ;)
</plug>
In fact, on the git list we tend to trim as little as possible.
Michael
Re: [PATCH] Add svnrdump
Posted by Michael J Gruber <gi...@drmicha.warpmail.net>.
Blair Zajac venit, vidit, dixit 09.07.2010 02:42:
> On 07/08/2010 01:17 AM, Daniel Shahaf wrote:
>> @Bert: could you please trim quoted patches to only the relevant parts?
>> Scrolling is tedious when I don't have have line folding available...
>
> +1 on this, in Thunderbird, it took a while to scan through the whole
> email to see the comments.
<plug>
That is what the QuoteCollapse extension to Thunderbird was invented for. ;)
</plug>
In fact, on the git list we tend to trim as little as possible.
Michael
Re: [PATCH] Add svnrdump
Posted by Michael J Gruber <gi...@drmicha.warpmail.net>.
Blair Zajac venit, vidit, dixit 09.07.2010 02:42:
> On 07/08/2010 01:17 AM, Daniel Shahaf wrote:
>> @Bert: could you please trim quoted patches to only the relevant parts?
>> Scrolling is tedious when I don't have have line folding available...
>
> +1 on this, in Thunderbird, it took a while to scan through the whole
> email to see the comments.
<plug>
That is what the QuoteCollapse extension to Thunderbird was invented for. ;)
</plug>
In fact, on the git list we tend to trim as little as possible.
Michael
Re: [PATCH] Add svnrdump
Posted by Blair Zajac <bl...@orcaware.com>.
On 07/08/2010 01:17 AM, Daniel Shahaf wrote:
> @Bert: could you please trim quoted patches to only the relevant parts?
> Scrolling is tedious when I don't have have line folding available...
+1 on this, in Thunderbird, it took a while to scan through the whole
email to see the comments.
Regards,
Blair