[GitHub] [incubator-eventmesh] abinaya-u commented on a diff in pull request #2029: [ISSUE#1082][Enhancement] Extraction of constants [example module grpc http directory]

[GitBox <gi...@apache.org>]

abinaya-u commented on code in PR #2029:
URL: https://github.com/apache/incubator-eventmesh/pull/2029#discussion_r1009020254


##########
eventmesh-examples/src/main/java/org/apache/eventmesh/common/ExampleConstants.java:
##########
@@ -51,4 +51,9 @@ public class ExampleConstants {
     public static final String EVENTMESH_SELECTOR_NACOS_ADDRESS = "eventmesh.selector.nacos.address";
 
     public static final String EVENTMESH_SELECTOR_TYPE = "eventmesh.selector.type";
+
+	public static final String env = "P";
+	public static final String idc = "FT";
+	public static final String subsys = "1234";
+	public static final String SERVER_PORT = "server.port";

Review Comment:
   changes have been made, please review again



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org