You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/27 13:57:15 UTC

[GitHub] [skywalking-website] wu-sheng opened a new pull request #186: Add doc about manual deployment.

wu-sheng opened a new pull request #186:
URL: https://github.com/apache/skywalking-website/pull/186


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-website] wu-sheng merged pull request #186: Add doc about manual deployment.

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #186:
URL: https://github.com/apache/skywalking-website/pull/186


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-website] kezhenxu94 commented on pull request #186: Add doc about manual deployment.

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #186:
URL: https://github.com/apache/skywalking-website/pull/186#issuecomment-751472228


   LGTM, feel free to merge anytime 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-website] kezhenxu94 commented on a change in pull request #186: Add doc about manual deployment.

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #186:
URL: https://github.com/apache/skywalking-website/pull/186#discussion_r549117826



##########
File path: README.md
##########
@@ -8,7 +8,7 @@ This site was compiled using [Hugo](https://gohugo.io).
 
 1. Install hugo
 1. Pull this repo into your local environment, and run `hugo server`  at the root folder, you can see the site preview from http://localhost:1313
-1. To generate the static website, run `hugo`
+1. To generate the static website, run `hugo`. According to ASF policy, the deployment has to be manually by a committer. Use the generated `public` folder to update the `asf-site` branch, and push the updates to the upstream.

Review comment:
       ```suggestion
   1. To generate the static website, run `hugo`. According to ASF policy, the deployment has to be manually done by a committer. Use the generated `public` folder to update the `asf-site` branch, and push the updates to the upstream.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org