You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/11/29 23:14:31 UTC
[Impala-ASF-CR] IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12008
Change subject: IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
......................................................................
IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
---
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_resource_management.xml
3 files changed, 204 insertions(+), 200 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/12008/1
--
To view, visit http://gerrit.cloudera.org:8080/12008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
Gerrit-Change-Number: 12008
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12008
to look at the new patch set (#2).
Change subject: IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
......................................................................
IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
---
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_resource_management.xml
3 files changed, 206 insertions(+), 200 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/12008/2
--
To view, visit http://gerrit.cloudera.org:8080/12008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
Gerrit-Change-Number: 12008
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12008 )
Change subject: IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12008/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/12008/1/docs/shared/impala_common.xml@3668
PS1, Line 3668: an Impala dynamic resource pool, you must also specify the Default Query
This looks like it needs updating since "Minimum Query Memory Limit" and "Maximum Query Memory Limit" is also an option.
http://gerrit.cloudera.org:8080/#/c/12008/1/docs/topics/impala_admission.xml
File docs/topics/impala_admission.xml:
http://gerrit.cloudera.org:8080/#/c/12008/1/docs/topics/impala_admission.xml@139
PS1, Line 139: This is the technique to use once you have a stable workload with well-understood memory requirements.
I feel like this sentence doesn't add anything.
http://gerrit.cloudera.org:8080/#/c/12008/1/docs/topics/impala_admission.xml@167
PS1, Line 167: e Default Query Memory Limit unset
I missed this in the draft I sent you - this note only applies if you set neither "Default..." or the Min/Max.
http://gerrit.cloudera.org:8080/#/c/12008/1/docs/topics/impala_admission.xml@697
PS1, Line 697: In a real
: deployment they might contain other settings for use with various
: aspects of the YARN component.
I find this sentence confusing. Maybe the paragraph should just say that these files define resource pools for Impala Admission Control and are separate from the similar fair-scheduler.xml that defines resource pools for YARN.
--
To view, visit http://gerrit.cloudera.org:8080/12008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
Gerrit-Change-Number: 12008
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 00:31:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12008 )
Change subject: IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/163/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
Gerrit-Change-Number: 12008
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 01:15:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12008 )
Change subject: IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/162/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
Gerrit-Change-Number: 12008
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Nov 2018 23:47:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12008 )
Change subject: IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12008/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/12008/1/docs/shared/impala_common.xml@3668
PS1, Line 3668: an Impala dynamic resource pool, you must also specify the Default Query
> This looks like it needs updating since "Minimum Query Memory Limit" and "M
This conref is not used anywhere. I will add a comment to remove it at some point
http://gerrit.cloudera.org:8080/#/c/12008/1/docs/topics/impala_admission.xml
File docs/topics/impala_admission.xml:
http://gerrit.cloudera.org:8080/#/c/12008/1/docs/topics/impala_admission.xml@139
PS1, Line 139: This is the technique to use once you have a stable workload with well-understood memory requirements.
> I feel like this sentence doesn't add anything.
Removed
http://gerrit.cloudera.org:8080/#/c/12008/1/docs/topics/impala_admission.xml@167
PS1, Line 167: e Default Query Memory Limit unset
> I missed this in the draft I sent you - this note only applies if you set n
Done
http://gerrit.cloudera.org:8080/#/c/12008/1/docs/topics/impala_admission.xml@697
PS1, Line 697: In a real
: deployment they might contain other settings for use with various
: aspects of the YARN component.
> I find this sentence confusing. Maybe the paragraph should just say that th
Done
--
To view, visit http://gerrit.cloudera.org:8080/12008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
Gerrit-Change-Number: 12008
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 01:06:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12008 )
Change subject: IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
......................................................................
IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
Reviewed-on: http://gerrit.cloudera.org:8080/12008
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_resource_management.xml
3 files changed, 206 insertions(+), 200 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
Gerrit-Change-Number: 12008
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12008 )
Change subject: IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/163/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
Gerrit-Change-Number: 12008
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 01:06:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12008 )
Change subject: IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/162/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
Gerrit-Change-Number: 12008
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Nov 2018 23:14:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12008 )
Change subject: IMPALA-7908: [DOCS] Doc automatic setting of memory limit for a query in admission control
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2272433e8dc464c188e0c82a24bf3d0409aa05b
Gerrit-Change-Number: 12008
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 01:15:38 +0000
Gerrit-HasComments: No