You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/01/03 21:31:09 UTC
Re: Review Request: Fixed libprocess BufferedRead test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8697/#review15052
-----------------------------------------------------------
Ship it!
src/files/files.cpp
<https://reviews.apache.org/r/8697/#comment32609>
new line
third_party/libprocess/src/tests.cpp
<https://reviews.apache.org/r/8697/#comment32610>
use ASSERT_SOME_TRUE
- Vinod Kone
On Dec. 20, 2012, 5:33 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8697/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2012, 5:33 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> Commented in MESOS-326.
>
>
> This addresses bug MESOS-326.
> https://issues.apache.org/jira/browse/MESOS-326
>
>
> Diffs
> -----
>
> src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813
> third_party/libprocess/include/process/io.hpp 8cf3244e55da95654cea34471ee1eea5e19c872e
> third_party/libprocess/src/tests.cpp 131154abc920fa3904b7fa79faedb63f8d593793
>
> Diff: https://reviews.apache.org/r/8697/diff/
>
>
> Testing
> -------
>
> make check in libprocess
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed libprocess BufferedRead test.
Posted by Ben Mahler <be...@gmail.com>.
> On Jan. 3, 2013, 8:31 p.m., Vinod Kone wrote:
> > third_party/libprocess/src/tests.cpp, line 1389
> > <https://reviews.apache.org/r/8697/diff/1/?file=241582#file241582line1389>
> >
> > use ASSERT_SOME_TRUE
Not possible within libprocess tests, although my test refactorings fix this in the other reviews.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8697/#review15052
-----------------------------------------------------------
On Dec. 20, 2012, 5:33 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8697/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2012, 5:33 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> Commented in MESOS-326.
>
>
> This addresses bug MESOS-326.
> https://issues.apache.org/jira/browse/MESOS-326
>
>
> Diffs
> -----
>
> src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813
> third_party/libprocess/include/process/io.hpp 8cf3244e55da95654cea34471ee1eea5e19c872e
> third_party/libprocess/src/tests.cpp 131154abc920fa3904b7fa79faedb63f8d593793
>
> Diff: https://reviews.apache.org/r/8697/diff/
>
>
> Testing
> -------
>
> make check in libprocess
>
>
> Thanks,
>
> Ben Mahler
>
>