[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8099: [WIP] Allow resizing width of SQL Lab left bar / editor

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #8099: [WIP] Allow resizing width of SQL Lab left bar / editor
URL: https://github.com/apache/incubator-superset/pull/8099#discussion_r316972088
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/SqlEditor.jsx
 ##########
 @@ -453,25 +458,36 @@ class SqlEditor extends React.PureComponent {
       </div>
     );
   }
+  leftBar() {
+    return (
+      <CSSTransition
+        classNames="schemaPane"
+        in={!this.props.hideLeftBar}
+        timeout={300}
+      >
+        <SqlEditorLeftBar
+          database={this.props.database}
+          queryEditor={this.props.queryEditor}
+          tables={this.props.tables}
+          actions={this.props.actions}
+        />
+      </CSSTransition>
+    );
+  }
   render() {
     return (
-      <div ref={this.sqlEditorRef} className="SqlEditor">
-        <CSSTransition
-          classNames="schemaPane"
-          in={!this.props.hideLeftBar}
-          timeout={300}
-        >
-          <div className="schemaPane">
-            <SqlEditorLeftBar
-              database={this.props.database}
-              queryEditor={this.props.queryEditor}
-              tables={this.props.tables}
-              actions={this.props.actions}
-            />
-          </div>
-        </CSSTransition>
+      <Split
+        ref={this.sqlEditorRef}
+        className={this.props.hideLeftBar ? 'SqlEditor-expanded' : 'SqlEditor'}
+        sizes={[INITIAL_WEST_PERCENT, INITIAL_EAST_PERCENT]}
 
 Review comment:
   do you want user's setting be persist when they reload or switch browser?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org