You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/12 19:40:41 UTC
[GitHub] [incubator-pinot] snleee commented on a change in pull request
#5146: Update pinot assembly scripts for release 0.3.0
snleee commented on a change in pull request #5146: Update pinot assembly scripts for release 0.3.0
URL: https://github.com/apache/incubator-pinot/pull/5146#discussion_r391849492
##########
File path: pinot-distribution/pinot-assembly.xml
##########
@@ -43,10 +43,74 @@
<file>
<source>${pinot.root}/DISCLAIMER</source>
</file>
+ <!-- Include Pinot All-in-one jar -->
<file>
<source>${pinot.root}/pinot-distribution/target/pinot-distribution-${project.version}-shaded.jar</source>
<destName>lib/pinot-all-${project.version}-jar-with-dependencies.jar</destName>
</file>
+ <!-- Start Include Pinot Plugins-->
+ <!-- Start Include Pinot Stream Ingestion Plugins-->
+ <!-- Only Include Specified Kafka Version Plugin-->
+ <file>
+ <source>${pinot.root}/pinot-plugins/pinot-stream-ingestion/pinot-kafka-${kafka.version}/target/pinot-kafka-${kafka.version}-${project.version}-shaded.jar</source>
Review comment:
After I run `mvn install`, I see `pinot-plugins/target/plugins` has all shaded plugins copied. Is it possible to copy this directory at once instead of listing all files?
```
~/workspace/pinot/pinot-plugins/target/plugins adls-gen2*
❯ pwd
/Users/snlee/workspace/pinot/pinot-plugins/target/plugins
~/workspace/pinot/pinot-plugins/target/plugins adls-gen2*
❯ ll
total 0
drwxr-xr-x 11 snlee LINKEDIN\eng 352B Mar 10 21:33 pinot-batch-ingestion
drwxr-xr-x 6 snlee LINKEDIN\eng 192B Mar 10 21:30 pinot-file-system
drwxr-xr-x 9 snlee LINKEDIN\eng 288B Mar 10 21:30 pinot-input-format
drwxr-xr-x 2 snlee LINKEDIN\eng 64B Mar 10 21:29 pinot-plugins
drwxr-xr-x 6 snlee LINKEDIN\eng 192B Mar 10 21:33 pinot-stream-ingestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org