You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/07 23:11:17 UTC

[GitHub] [kafka] hachikuji commented on a diff in pull request #12250: KAFKA-13935 Fix static usages of IBP in KRaft mode

hachikuji commented on code in PR #12250:
URL: https://github.com/apache/kafka/pull/12250#discussion_r891771090


##########
core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala:
##########
@@ -106,7 +110,8 @@ class RemoteLeaderEndPoint(logPrefix: String,
           .setPartitionIndex(topicPartition.partition)
           .setCurrentLeaderEpoch(currentLeaderEpoch)
           .setTimestamp(earliestOrLatest)))
-    val requestBuilder = ListOffsetsRequest.Builder.forReplica(brokerConfig.listOffsetRequestVersion, brokerConfig.brokerId)
+    val meteadataVersion = metadataVersionSupplier()

Review Comment:
   nit: typo `meteadataVersion`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org