You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Pavel Yaskevich (Commented) (JIRA)" <ji...@apache.org> on 2012/02/09 20:16:00 UTC
[jira] [Commented] (CASSANDRA-3877) Make secondary indexes inherit
compression (and maybe other properties) from their base CFS
[ https://issues.apache.org/jira/browse/CASSANDRA-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204750#comment-13204750 ]
Pavel Yaskevich commented on CASSANDRA-3877:
--------------------------------------------
+1 with one nit: reloadSecondaryIndexMetadata can be made to return CFMetadata (this) so instead of using variable in the CFMetaData.newIndexMetadata(...) it can be called in chaining style like all other methods.
{noformat}
- .gcGraceSeconds(parent.gcGraceSeconds)
- .minCompactionThreshold(parent.minCompactionThreshold)
- .maxCompactionThreshold(parent.maxCompactionThreshold);
+ .reloadSecondaryIndexMetadata(parent);
+ }
+
+ public CFMetaData reloadSecondaryIndexMetadata(CFMetaData parent)
+ {
+ gcGraceSeconds(parent.gcGraceSeconds);
+ minCompactionThreshold(parent.minCompactionThreshold);
+ maxCompactionThreshold(parent.maxCompactionThreshold);
+ compactionStrategyClass(parent.compactionStrategyClass);
+ compactionStrategyOptions(parent.compactionStrategyOptions);
+ compressionParameters(parent.compressionParameters);
+
+ return this;
{noformat}
> Make secondary indexes inherit compression (and maybe other properties) from their base CFS
> -------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-3877
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3877
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.1.0
>
> Attachments: 3877.patch
>
>
> Secondary indexes currently use the defaults for most properties and only inherit a few properties from their base CFS (namely gc_grace and the min/max compaction thresholds currently). It would make sense to have them inherit more properties. At least compression makes sense, but the compaction parameters probably do too (and maybe bf_filter_chance?).
> In any case, making secondary indexes inherit those probably is trivial, but I think we should also make it so that if the base CF is modified, we mirror the changes to it's secondary indexes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira