You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2023/09/11 16:09:07 UTC
[GitHub] [arrow] thisisnic opened a new pull request, #37658: GH-34640: [R] Can't read in partitioning column in CSV datasets when both (non-hive) partition and schema supplied
thisisnic opened a new pull request, #37658:
URL: https://github.com/apache/arrow/pull/37658
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on a diff in pull request #37658: GH-34640: [R] Can't read in partitioning column in CSV datasets when both (non-hive) partition and schema supplied
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #37658:
URL: https://github.com/apache/arrow/pull/37658#discussion_r1338638956
##########
r/tests/testthat/test-dataset-csv.R:
##########
@@ -593,3 +593,36 @@ test_that("CSVReadOptions field access", {
expect_equal(options$block_size, 1048576L)
expect_equal(options$encoding, "UTF-8")
})
+
+test_that("GH-34640 - CSV datasets are read in correctly when both schema and partitioning supplied", {
+
+ target_schema <- schema(
+ int = int64(), dbl = float16(), lgl = bool(), chr = utf8(),
+ fct = utf8(), ts = timestamp(unit = "s"), part = int32()
+ )
+
+ ds <- open_dataset(
+ csv_dir,
+ partitioning = schema(part = int32()),
+ format = "csv",
+ schema = target_schema,
+ skip = 1
+ )
+ expect_r6_class(ds$format, "CsvFileFormat")
+ expect_r6_class(ds$filesystem, "LocalFileSystem")
+ expect_identical(names(ds), c(names(df1), "part"))
+ expect_identical(dim(ds), c(20L, 7L))
+ expect_equal(schema(ds), target_schema)
+
Review Comment:
Maybe also:
```r
expect_identical(names(collect(ds)), c(names(df1), "part"))
```
(I seem to remember there are some things that don't happen until a dataset is collected)
##########
r/R/dataset-format.R:
##########
@@ -223,7 +227,7 @@ check_csv_file_format_args <- function(args) {
}
if (is.null(args$read_options)) {
- options$read_options <- do.call(csv_file_format_read_opts, args)
+ options$read_options <- do.call(csv_file_format_read_opts, c(args, partitioning = partitioning))
Review Comment:
```suggestion
options$read_options <- do.call(csv_file_format_read_opts, c(args, list(partitioning = partitioning)))
```
(I think `c(something_that_is_a_list, some_name = something_that_could_be_anything)` often, but not always, results in the output being a list...wrapping the second bit in a `list()` always works)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37658: GH-34640: [R] Can't read in partitioning column in CSV datasets when both (non-hive) partition and schema supplied
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37658:
URL: https://github.com/apache/arrow/pull/37658#issuecomment-1714187562
:warning: GitHub issue #34640 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37658: GH-34640: [R] Can't read in partitioning column in CSV datasets when both (non-hive) partition and schema supplied
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37658:
URL: https://github.com/apache/arrow/pull/37658#issuecomment-1740628068
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 9d3806a27747241c5daf2ecc901986c16962ead2.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17248939345) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a diff in pull request #37658: GH-34640: [R] Can't read in partitioning column in CSV datasets when both (non-hive) partition and schema supplied
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #37658:
URL: https://github.com/apache/arrow/pull/37658#discussion_r1338725604
##########
r/tests/testthat/test-dataset-csv.R:
##########
@@ -593,3 +593,36 @@ test_that("CSVReadOptions field access", {
expect_equal(options$block_size, 1048576L)
expect_equal(options$encoding, "UTF-8")
})
+
+test_that("GH-34640 - CSV datasets are read in correctly when both schema and partitioning supplied", {
+
+ target_schema <- schema(
+ int = int64(), dbl = float16(), lgl = bool(), chr = utf8(),
+ fct = utf8(), ts = timestamp(unit = "s"), part = int32()
+ )
+
+ ds <- open_dataset(
+ csv_dir,
+ partitioning = schema(part = int32()),
+ format = "csv",
+ schema = target_schema,
+ skip = 1
+ )
+ expect_r6_class(ds$format, "CsvFileFormat")
+ expect_r6_class(ds$filesystem, "LocalFileSystem")
+ expect_identical(names(ds), c(names(df1), "part"))
+ expect_identical(dim(ds), c(20L, 7L))
+ expect_equal(schema(ds), target_schema)
+
Review Comment:
Good call, updated now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic merged pull request #37658: GH-34640: [R] Can't read in partitioning column in CSV datasets when both (non-hive) partition and schema supplied
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic merged PR #37658:
URL: https://github.com/apache/arrow/pull/37658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org