You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/09 12:09:28 UTC
[GitHub] [superset] wiktor2200 opened a new pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
wiktor2200 opened a new pull request #18642:
URL: https://github.com/apache/superset/pull/18642
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Redis with password was not supported out-of-the-box, so I've added this support in celery config in _helpers. When variable: `redis_password` in section: `supersetNode.connections` other version of config script is created during init.
I've also updated quite ancient version of Redis helm chart in dependencies.
Update process was performed according to this doc: https://artifacthub.io/packages/helm/bitnami/redis/16.3.1
I've also added small fix in documentation for helm chart. #18641
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
I've updated values.yaml json schema. `helm lint` command runs successfully. I've also checked helm templates if configs are generated without any missing/additional white space.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m commented on a change in pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
ad-m commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r803249440
##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -89,6 +89,21 @@ WTF_CSRF_ENABLED = True
WTF_CSRF_EXEMPT_LIST = []
# A CSRF token that expires in 1 year
WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
+{{- if .Values.supersetNode.connections.redis_password }}
+class CeleryConfig(object):
Review comment:
I have in mind something like:
```
class CeleryConfig(object):
CELERY_RESULT_BACKEND = f"redis://{env('REDIS_PASSWORD')}@{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
CELERY_ANNOTATIONS = {'tasks.add': {'rate_limit': '10/s'}}
CELERY_IMPORTS = ('superset.sql_lab', )
{{- if .Values.supersetNode.connections.redis_password }}
BROKER_URL = f"redis://{env('REDIS_PASSWORD')}@{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
{{- else }}
BROKER_URL = f"redis://{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
{{- end -}}
CELERY_CONFIG = CeleryConfig
RESULTS_BACKEND = RedisCache(
host=env('REDIS_HOST'),
{{- if .Values.supersetNode.connections.redis_password }}
password=env('REDIS_PASSWORD'),
{{- end -}}
port=env('REDIS_PORT'),
key_prefix='superset_results'
)
```
Do you think readability has been maintained?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #18642:
URL: https://github.com/apache/superset/pull/18642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on a change in pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r803634447
##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -89,6 +89,21 @@ WTF_CSRF_ENABLED = True
WTF_CSRF_EXEMPT_LIST = []
# A CSRF token that expires in 1 year
WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
+{{- if .Values.supersetNode.connections.redis_password }}
+class CeleryConfig(object):
Review comment:
Thanks for your feedback! And please take a look once again. @craig-rueda @ad-m
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on pull request #18642:
URL: https://github.com/apache/superset/pull/18642#issuecomment-1040324036
Hello @craig-rueda something went wrong with promoting these changes as release.
I guess it was cause of merging this one and https://github.com/apache/superset/pull/18649 with the same release version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m commented on a change in pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
ad-m commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r803195078
##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -89,6 +89,21 @@ WTF_CSRF_ENABLED = True
WTF_CSRF_EXEMPT_LIST = []
# A CSRF token that expires in 1 year
WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
+{{- if .Values.supersetNode.connections.redis_password }}
+class CeleryConfig(object):
Review comment:
Some lines are duplicated in both condition situations. I wonder if we want to have two ifs or if we want duplicate code. I think it's better not to have two ifs than duplicate code, because then it's easier to maintain consistency when a new parameter is added in the middle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on pull request #18642:
URL: https://github.com/apache/superset/pull/18642#issuecomment-1033694417
@ad-m Could you take a look on `values.yaml.json` schema and review it?
@craig-rueda Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on a change in pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r803624555
##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -89,6 +89,21 @@ WTF_CSRF_ENABLED = True
WTF_CSRF_EXEMPT_LIST = []
# A CSRF token that expires in 1 year
WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
+{{- if .Values.supersetNode.connections.redis_password }}
+class CeleryConfig(object):
+ BROKER_URL = f"redis://{env('REDIS_PASSWORD')}@{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
Review comment:
Ok, I've changed (added colon) and I made sure one again, so both external redis and superset-redis from dependencies works well.
```
I have no name!@superset-redis-master-0:/$ redis-cli --stat --askpass
Please input password: ********
------- data ------ --------------------- load -------------------- - child -
keys mem clients blocked requests connections
3 1.04M 11 1 915 (+0) 160
3 1.04M 11 1 917 (+2) 160
3 1.04M 11 1 920 (+3) 160
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on a change in pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r803611055
##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -89,6 +89,21 @@ WTF_CSRF_ENABLED = True
WTF_CSRF_EXEMPT_LIST = []
# A CSRF token that expires in 1 year
WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
+{{- if .Values.supersetNode.connections.redis_password }}
+class CeleryConfig(object):
+ BROKER_URL = f"redis://{env('REDIS_PASSWORD')}@{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
Review comment:
Hmm... that's weird, I tested it in minikube and it worked. I've checked logs in both superset and redis (no errors) and info about successfully connected clients in redis.
```
DB 0: 3 keys (0 volatile) in 4 slots HT.
10 clients connected (0 replicas), 1022392 bytes in use
```
But docs says different thing and you've got right that it's better to stick to documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on pull request #18642:
URL: https://github.com/apache/superset/pull/18642#issuecomment-1041260851
I've created this PR: #18751, please merge @craig-rueda.
@ad-m if this one will be merged it will affect your changes here: https://github.com/apache/superset/pull/18668/files#diff-23d50af2c34a57c2eef8579ccda92efbfc0fd81e189851948d9e2b556a5d45cc
so you will also need to bump version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on pull request #18642:
URL: https://github.com/apache/superset/pull/18642#issuecomment-1040324036
Hello @craig-rueda something went wrong with promoting these changes as release.
I guess it was cause of merging this one and https://github.com/apache/superset/pull/18649 with the same release version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yzliao-zip commented on a change in pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
yzliao-zip commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r838058351
##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -90,14 +90,22 @@ WTF_CSRF_EXEMPT_LIST = []
# A CSRF token that expires in 1 year
WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
class CeleryConfig(object):
- BROKER_URL = f"redis://{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
CELERY_IMPORTS = ('superset.sql_lab', )
- CELERY_RESULT_BACKEND = f"redis://{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
CELERY_ANNOTATIONS = {'tasks.add': {'rate_limit': '10/s'}}
+{{- if .Values.supersetNode.connections.redis_password }}
Review comment:
I think the check of `auth.enabled` is needed here. Otherwise, the redis without password is connected with an incorrect url because the default value in `value.yaml` is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 commented on a change in pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
wiktor2200 commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r803633563
##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -89,6 +89,21 @@ WTF_CSRF_ENABLED = True
WTF_CSRF_EXEMPT_LIST = []
# A CSRF token that expires in 1 year
WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
+{{- if .Values.supersetNode.connections.redis_password }}
+class CeleryConfig(object):
Review comment:
It makes sense. I've tried it this way before but I wanted diff to be minimal, so I didn't want to change order od parameters. I changed it, because I agree that when it will become bigger one of if/else/end could be omitted and cause lots of troubleshooting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a change in pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r803235325
##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -89,6 +89,21 @@ WTF_CSRF_ENABLED = True
WTF_CSRF_EXEMPT_LIST = []
# A CSRF token that expires in 1 year
WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
+{{- if .Values.supersetNode.connections.redis_password }}
+class CeleryConfig(object):
Review comment:
I thought the same thing, but drying that up will be a little tricky and will likely make the code less readable in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wiktor2200 edited a comment on pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
wiktor2200 edited a comment on pull request #18642:
URL: https://github.com/apache/superset/pull/18642#issuecomment-1033694417
@ad-m Could you take a look on `values.schema.json` schema and review it?
@craig-rueda Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m commented on a change in pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
ad-m commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r803195702
##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -89,6 +89,21 @@ WTF_CSRF_ENABLED = True
WTF_CSRF_EXEMPT_LIST = []
# A CSRF token that expires in 1 year
WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
+{{- if .Values.supersetNode.connections.redis_password }}
+class CeleryConfig(object):
+ BROKER_URL = f"redis://{env('REDIS_PASSWORD')}@{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
Review comment:
Are you sure that it gonna works? Celery [documentation use](https://docs.celeryproject.org/en/stable/getting-started/backends-and-brokers/redis.html#configuration) `redis://:password@hostname:port/db_number`, nor `redis://password@hostname:port/db_number` (compare collon before password).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m commented on a change in pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
ad-m commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r803249440
##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -89,6 +89,21 @@ WTF_CSRF_ENABLED = True
WTF_CSRF_EXEMPT_LIST = []
# A CSRF token that expires in 1 year
WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
+{{- if .Values.supersetNode.connections.redis_password }}
+class CeleryConfig(object):
Review comment:
I have in mind something like:
```
class CeleryConfig(object):
CELERY_ANNOTATIONS = {'tasks.add': {'rate_limit': '10/s'}}
CELERY_IMPORTS = ('superset.sql_lab', )
{{- if .Values.supersetNode.connections.redis_password }}
CELERY_RESULT_BACKEND = f"redis://{env('REDIS_PASSWORD')}@{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
BROKER_URL = f"redis://{env('REDIS_PASSWORD')}@{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
{{- else }}
CELERY_RESULT_BACKEND = f"redis://{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
BROKER_URL = f"redis://{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
{{- end -}}
CELERY_CONFIG = CeleryConfig
RESULTS_BACKEND = RedisCache(
host=env('REDIS_HOST'),
{{- if .Values.supersetNode.connections.redis_password }}
password=env('REDIS_PASSWORD'),
{{- end -}}
port=env('REDIS_PORT'),
key_prefix='superset_results'
)
```
Do you think readability has been maintained?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m commented on pull request #18642: feat(Helm): Redis with password supported in helm charts and redis chart version updated
Posted by GitBox <gi...@apache.org>.
ad-m commented on pull request #18642:
URL: https://github.com/apache/superset/pull/18642#issuecomment-1040973640
> Hello @craig-rueda something went wrong with promoting these changes as release. I guess it was cause of merging this one and #18649 with the same release version.
Could you provide PR to bump version one more time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org