You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/06 19:30:10 UTC

[GitHub] [incubator-nuttx] acassis commented on pull request #6375: stm32wl5: add new chip family

acassis commented on PR #6375:
URL: https://github.com/apache/incubator-nuttx/pull/6375#issuecomment-1147823454

   Very nice @mlyszczek !!!
   Could you please fix these coding style issues:
   ```
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/stm32wl5/chip.h:2:1: error: Relative file path does not match actual file
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/stm32wl5/stm32wl5xxx_cpu1_irq.h:118:1: error: Too many blank lines
   Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/stm32wl5/hardware/stm32wl5_flash.h:228:60: warning: Wrong column position of comment right of code
   Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/stm32wl5/hardware/stm32wl5_flash.h:229:60: warning: Wrong column position of comment right of code
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/stm32wl5/hardware/stm32wl5_pwr.h:123:43: error: Wrong column position or missing blank line before comment
   Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/stm32wl5/hardware/stm32wl5_pwr.h:124:43: warning: Wrong column position of comment right of code
   Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/stm32wl5/hardware/stm32wl5_rcc.h:278:76: warning: Wrong column position of comment right of code
   Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/stm32wl5/hardware/stm32wl5_uart.h:204:44: warning: Wrong column position of comment right of code
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org