You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/04/10 19:48:36 UTC

[kudu-CR] KUDU-2191 (10/n): Hive Metastore notification log event listener

Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8313

to look at the new patch set (#4).

Change subject: KUDU-2191 (10/n): Hive Metastore notification log event listener
......................................................................

KUDU-2191 (10/n): Hive Metastore notification log event listener

This commit adds a notification log event listener to the Hive Metastore
integration. The leader master now listens for drop table and alter
table events in the HMS, and applies them to the Kudu catalog as
necessary. The latest handled notification log event index is recorded
in the sys-catalog.

Testing: this is a hard component to test, because it is necessarily
tied to the catalog manager. I've added tests for specific scenarios in
master_hms-itest, however I'm aware that not all codepaths in the
listener are covered. master-stress-test now has the HMS integration
enabled, since this was the 'missing piece' which allows the catalogs to
remain (eventually) consistent in the presence of master crashes.

Change-Id: I32ed099c44a593ffe514152135957018f21ed775
---
M build-support/iwyu/iwyu-filter.awk
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client-test.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/master/CMakeLists.txt
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
A src/kudu/master/hms_notification_log_listener.cc
A src/kudu/master/hms_notification_log_listener.h
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
13 files changed, 627 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/8313/4
-- 
To view, visit http://gerrit.cloudera.org:8080/8313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I32ed099c44a593ffe514152135957018f21ed775
Gerrit-Change-Number: 8313
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot