You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/10/13 12:17:28 UTC

[PR] Improve .scala-steward.conf [incubator-pekko]

mdedetrich opened a new pull request, #707:
URL: https://github.com/apache/incubator-pekko/pull/707

   Let me know if any other additions/removals need to be done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] Improve .scala-steward.conf [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #707:
URL: https://github.com/apache/incubator-pekko/pull/707#discussion_r1358246280


##########
.scala-steward.conf:
##########
@@ -1,7 +1,4 @@
-pullRequests.frequency = "@monthly"
-
 updates.ignore = [
-  { groupId = "com.google.protobuf", artifactId = "protobuf-java" }

Review Comment:
   Done, I added it back in but in a better spot



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] Improve .scala-steward.conf [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #707:
URL: https://github.com/apache/incubator-pekko/pull/707


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] Improve .scala-steward.conf [incubator-pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #707:
URL: https://github.com/apache/incubator-pekko/pull/707#discussion_r1358188876


##########
.scala-steward.conf:
##########
@@ -1,7 +1,4 @@
-pullRequests.frequency = "@monthly"
-
 updates.ignore = [
-  { groupId = "com.google.protobuf", artifactId = "protobuf-java" }

Review Comment:
   I think we should ignore protobuf-java. Newer versions have breaking changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org