[GitHub] [cassandra] maedhroz commented on a change in pull request #1541: CASSANDRA-17510 streaming three min timeout

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #1541:
URL: https://github.com/apache/cassandra/pull/1541#discussion_r840193777



##########
File path: test/unit/org/apache/cassandra/net/AsyncStreamingInputPlusTest.java
##########
@@ -161,6 +129,61 @@ public void available_ClosedButWithBytes()
         Assert.assertEquals(size, inputPlus.unsafeAvailable());
     }
 
+    @Test
+    public void rebufferAndCloseToleratesInterruption() throws InterruptedException
+    {
+        ByteBuf beforeInterrupt = channel.alloc().heapBuffer(1024);
+        beforeInterrupt.writeCharSequence("BEFORE", Charset.forName("us-ascii"));

Review comment:
       ```suggestion
           beforeInterrupt.writeCharSequence("BEFORE", StandardCharsets.US_ASCII);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org