You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by sohami <gi...@git.apache.org> on 2018/04/16 22:40:45 UTC

[GitHub] drill pull request #1211: DRILL-6322: Lateral Join: Common changes - Add new...

GitHub user sohami opened a pull request:

    https://github.com/apache/drill/pull/1211

    DRILL-6322: Lateral Join: Common changes - Add new iterOutcome, Operator types, MockRecordBatch for testing

    @parthchandra - Please review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sohami/drill DRILL-6322

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1211.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1211
    
----
commit 2dbc6768857a0b8cd3e6e8c19fc133af2abf20d3
Author: Sorabh Hamirwasia <sh...@...>
Date:   2018-02-05T21:12:15Z

    DRILL-6322: Lateral Join: Common changes - Add new iterOutcome, Operatortypes, MockRecordBatch for testing
                Note: Added new Iterator State EMIT, added operatos LATERA_JOIN & UNNEST in CoreOperatorType and added LateralContract interface

commit 15655ab3543521ff56f4d426ebf7ed4884eb3006
Author: Sorabh Hamirwasia <sh...@...>
Date:   2018-02-07T21:29:28Z

    DRILL-6322: Lateral Join: Common changes - Add new iterOutcome, Operatortypes, MockRecordBatch for testing
                Note: Implementation of MockRecordBatch to test operator behavior for different IterOutcomes.
                      a) Creates new output container for schema change cases.
                      b) Doesn't create new container for each next() call without schema change, since the operator in test expects the ValueVector object in it's
                         incoming batch to be same unless a OK_NEW_SCHEMA case is hit. Since setup() method of operator in test will store the reference to value vector received in first batch

----


---

[GitHub] drill pull request #1211: DRILL-6322: Lateral Join: Common changes - Add new...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/1211


---

[GitHub] drill issue #1211: DRILL-6322: Lateral Join: Common changes - Add new iterOu...

Posted by parthchandra <gi...@git.apache.org>.

Github user parthchandra commented on the issue:

    https://github.com/apache/drill/pull/1211
  
    +1


---