[GitHub] [spark] yoda-mon commented on pull request #34896: [SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function

[GitBox <gi...@apache.org>]

yoda-mon commented on pull request #34896:
URL: https://github.com/apache/spark/pull/34896#issuecomment-995646224


   @MaxGekk Let me confirm how to extends `TimeZoneAwareExpression`.
   At first I simply extends basic constructor which takes 3 arguments and overides `timeZoneId` and `withTimeZone`
   https://github.com/yoda-mon/spark/pull/2/files
   It seems to work fine and passed all tests, but I wonder if you want me to extends the constructor which takes 2 arguments, or to use `withTimeZone` in the constructor.
   I took auxiliary constructor for case class, so I think it is difficult to implement both two ways. Should I switch to use  companion object ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org