You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jvwing <gi...@git.apache.org> on 2017/03/12 00:46:03 UTC
[GitHub] nifi pull request #1587: NIFI-2907 Fix Flow Schema Validation Errors
GitHub user jvwing opened a pull request:
https://github.com/apache/nifi/pull/1587
NIFI-2907 Fix Flow Schema Validation Errors
This PR contains two changes to flow.xml schema validation:
1.) Schema validation errors are now handled and logged to the nifi-app.log file as warnings, with text indicating that these are schema validation errors for the flow configuration. This should eliminate ominously vague nastygrams in the bootstrap log file. The new warnings look like this:
> 2017-03-11 12:36:13,329 WARN [main] o.a.n.c.StandardFlowSynchronizer Schema validation error parsing Flow Configuration at line 52, col 40: cvc-complex-type.2.4.a: Invalid content was found starting with element 'template'. One of '{processor, inputPort, outputPort, label, funnel, processGroup, remoteProcessGroup, connection, controllerService}' is expected.
2.) The FlowConfiguration.xsd schema has been updated to include templates. I did not detail the schema of the `snippet` element that forms most of a template, for the following reasons:
* I'm lazy
* While the snippet contents are logically similar to the RootProcessGroupType or ProcessGroupType, snippets are serialized through a different process which produces different element names and element ordering. I do not believe it is possible to reuse the schema types for processors, process groups, connectors, etc. A new parallel set of snippet-specific schema types would be needed, and I'm not convinced that would add value to the validation.
* Combining the two factors above, I decided that addressing the validation errors for templates was enough.
----
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jvwing/nifi NIFI-2907-flow-schema-errors-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1587.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1587
----
commit d3fbfb070318ceb1de138261dcf68254ab28b61e
Author: James Wing <jv...@gmail.com>
Date: 2017-03-11T20:59:33Z
NIFI-2907 Fix Flow Schema Validation Errors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1587: NIFI-2907 Fix Flow Schema Validation Errors
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1587
@jvwing OK, got this reviewed. As far as I can tell it all follows exactly what we write out now. Many thanks for getting this addressed. Sorry it took so long to review! Got it merged to master now though. Thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1587: NIFI-2907 Fix Flow Schema Validation Errors
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1587
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1587: NIFI-2907 Fix Flow Schema Validation Errors
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1587
Thanks, @markap14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---